Repository navigation
chore(deps): bump webware-tools to 1.0.0-rc.6 - #27
Merged
Merged
Conversation
Moves the dev dependency from ^1.0.0-rc.5 to ^1.0.0-rc.6. The rc.6 vendored mago.toml pins mago 1.57.0 instead of 1.55.0 and drops preserve-breaking-member-access-chain-first-method-on-same-line. mago format produces no diff in this repo under the new pin, so only the dependency change and the baseline reconciliation are required.
Mago 1.57.0 no longer reports the possibly-invalid-argument finding on IteratorIterator::__construct in src/NavigationFilterIterator.php, so the only entry in the baseline became orphaned and mago warned that it no longer matched any issue. The entry is removed with mago's own --remove-outdated-baseline-entries so the baseline is rewritten by the tool rather than by hand. The file previously held that single entry and is now empty, written in mago's own empty form (variant plus issues = []). Under 1.57.0 the analyzer reports no findings at all in this repo, confirmed against a baseline-ignoring run, so an empty baseline is complete rather than lossy. No source behaviour changed and no source file was touched. The underlying source finding is deferred to a later components burndown pass rather than fixed here.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the dev dependency
webware/webware-toolsfrom^1.0.0-rc.5to^1.0.0-rc.6.Two changes in rc.6 reach this repo:
mago.tomlpins mago1.57.0(was1.55.0). This repo's ownmago.tomlis extends-only, so the pin is inherited from the vendor tree.preserve-breaking-member-access-chain-first-method-on-same-lineis dropped, so its effective value is now false andmago formatstarts a fluent chain on the receiver line.Formatting
No formatting commit:
mago formatproduces no diff in this repo under the 1.57.0 pin. The existing layout already satisfies the new chain default.Baseline reconciliation
Mago 1.57.0 changed the text of several analyzer messages and, here, stopped reporting a finding outright. Baseline entries are keyed on diagnostic message text, so the entry written by 1.55.0 stopped matching its finding and mago reported the baseline as containing an entry for an issue that no longer exists.
The orphaned entry was removed with mago's own
--remove-outdated-baseline-entries, so the file was rewritten by the tool rather than edited by hand.The removed entry was
possibly-invalid-argumentonIteratorIterator::__constructinsrc/NavigationFilterIterator.php. It was the only entry in the file, so the baseline is now empty and is written in mago's own empty form (variantplusissues = []).Under 1.57.0 the analyzer reports no findings at all in this repo, confirmed against a baseline-ignoring run, so an empty baseline is complete rather than lossy.
No source behaviour changed and no source file was modified. The underlying finding is deferred to a later components burndown pass rather than fixed here.
mago analyzenow exits 0 with no outdated-entry warning, and consecutive runs are identical, which confirms the baseline matches 1.57.0 output exactly.Gate results
mago format --checkmago lintmago analyzemago guardTests:
composer testexit 0, 23 tests / 42 assertions.composer test-integrationexit 0, 1 test / 6 assertions.