Repository navigation
chore: state the package purpose in the composer description - #13
Merged
Merged
Conversation
The description named an implementation tactic ("shadows the PhpDb root
namespace") rather than what the package is for. Read cold, it suggests the
package overrides another library's namespace, which is not a claim this
package should be making in published metadata.
Description is now the one line of plain purpose.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
webware-phpdb'scomposer.jsondescription:Why
The old text named an implementation tactic instead of the package's purpose. Read cold, "shadows the PhpDb root namespace" suggests the package overrides another library's namespace, which is a misleading claim to publish in package metadata. The description is now the single line of what the package is.
Verification
composer.jsonparses cleanly. No other hand-written copy of the phrase exists in the repository.The phrase still appears in several
composer.lockfiles across the fleet. Those are generated records of the installed package version and will pick up the new description on the next dependency refresh; they are not edited by hand.