Update RFC 086 to reflect what was actually built - #172
Merged
Merged
Conversation
Phases 0-6 have shipped, but the RFC still said "Status: Not started" with every phase unticked. More importantly, the phase documents use names the implementation never adopted - ItemViewerContextV2, the .legacy.tsx/.refactored.tsx filename suffixes, and an iiifViewerRefactored toggle - none of which appear in the codebase. Phase 7 is the only phase still outstanding, and as written every path in its mv/rm commands is fictional. - README: status, progress ticked with ticket links, and a table translating the provisional names to the real ones - Phase 7: steps rewritten against the real layout, plus three the original missed - collapsing the context barrel, consolidating the import paths, and unpicking the dual-context test harness - Phase 6: records that it became an audit rather than the planned find-and-replace, and what that turned up - Phases 0-5: success criteria checked off against the code, with the three that weren't met left unticked and annotated - Migration checklist: phase 6 and 7 rows brought in line The remaining documents that mention the old names are left alone, as records of phases already delivered. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
rcantin-w
marked this pull request as ready for review
September 16, 2026 08:04
rcantin-w
requested review from
davidpmccormick
and removed request for
a team
September 16, 2026 08:05
davidpmccormick
approved these changes
Sep 16, 2026
| - [x] Phase 2: Split MainViewer Components - [#12985](https://github.com/wellcomecollection/wellcomecollection.org/issues/12985) | ||
| - [x] Phase 3: Canvas Data (with automated tests) - [#12986](https://github.com/wellcomecollection/wellcomecollection.org/issues/12986) | ||
| - [x] Phase 4: Download Logic - [#12987](https://github.com/wellcomecollection/wellcomecollection.org/issues/12987) | ||
| - [x] Phase 5: Restriction Status - [#13412](https://github.com/wellcomecollection/wellcomecollection.org/pull/13412) |
Contributor
There was a problem hiding this comment.
Suggest linking to the issue (#12988) instead of the PR (#13412) for consistency?
Contributor
Author
There was a problem hiding this comment.
@copilot can you do that? (I've no idea I'm trying it)
Contributor
There was a problem hiding this comment.
Done in b6f0fc0 — phase 5 now links to issue #12988 instead of PR #13412.
Co-authored-by: rcantin-w <110461050+rcantin-w@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
RFC 086 still said "Status: Not started" with every phase unticked, despite phases 0-6 having shipped. More to the point, the phase documents were written before implementation and use names the code never adopted -
ItemViewerContextV2, the.legacy.tsx/.refactored.tsxfilename suffixes, and aniiifViewerRefactoredtoggle. None of those appear anywhere in wellcomecollection.org. Phase 7 is the only phase still outstanding, and as written every path in itsmv/rmcommands is fictional.README.md- status and last-modified updated, phases 0-6 ticked with links to their tickets, plus a table translating the provisional names to the real ones (contexts/ItemViewerContext/refactored.tsx,legacy//refactored/directories,itemViewerRefactor). Also fixes a mangled principle 8/9 and a missing blank line.13-phase-7-cleanup.md- steps rewritten against the actual layout so they can be followed. Adds three the original missed: collapsing the context barrel, getting every consumer onto one import path, and unpicking the dual-context test harness inrender.tsx. Fixes a broken link to15-risks-and-success.md.12-phase-6-duplicate-calls.md- records that this phase became an audit rather than the planned find-and-replace, what it turned up (one real duplicate inGridViewer), and the four lookalikes deliberately left alone.06through11- each phase's success criteria checked off against the code.13-migration-checklist.md- phase 6 and 7 rows brought in line.rfcs/README.md- regenerated by the pre-commit hook, since 086 is now the most recently modified RFC.Three criteria are left unticked because they genuinely weren't met, each annotated with what happened instead:
isCurrentCanvasRestrictedactually gates is hiding the download button on a restricted canvas.currentCanvasIndexfrom context" - that value was deliberately never added to the context, since it would duplicatequery.canvas.Two more are left unticked because the code can't evidence them: phase 0's "all team members understand what types exist", and phase 3's optional manual testing checklist. Each phase's separate manual-testing checklist is also still unticked, for the same reason.
The eight documents that mention the old provisional names are otherwise left alone, as records of phases already delivered; the README table covers reading them.
How to test
Read it. All relative links resolve, and every ticket number was checked against the GitHub API.
Have we considered potential risks?
Docs only, nothing deployed. The risk runs the other way: phase 7 is the one part anyone still has to follow, so if its rewritten steps are wrong, someone hits that at cleanup time - worth a careful read of that file specifically. The counts in step 7.5 (32 files importing the context barrel, 16 importing
refactoreddirectly) are from today's main and will drift, so they're written as a grep to re-run rather than a number to trust.Written by Claude Code.