Skip to content

Update RFC 086 to reflect what was actually built - #172

Merged
rcantin-w merged 3 commits into
mainfrom
rfc-086-update-status-and-stale-instructions
Sep 16, 2026
Merged

rcantin-w merged 3 commits into
mainfrom
rfc-086-update-status-and-stale-instructions

Conversation

@rcantin-w

Copy link
Copy Markdown
Contributor

What does this change?

RFC 086 still said "Status: Not started" with every phase unticked, despite phases 0-6 having shipped. More to the point, the phase documents were written before implementation and use names the code never adopted - ItemViewerContextV2, the .legacy.tsx/.refactored.tsx filename suffixes, and an iiifViewerRefactored toggle. None of those appear anywhere in wellcomecollection.org. Phase 7 is the only phase still outstanding, and as written every path in its mv/rm commands is fictional.

  • README.md - status and last-modified updated, phases 0-6 ticked with links to their tickets, plus a table translating the provisional names to the real ones (contexts/ItemViewerContext/refactored.tsx, legacy//refactored/ directories, itemViewerRefactor). Also fixes a mangled principle 8/9 and a missing blank line.
  • 13-phase-7-cleanup.md - steps rewritten against the actual layout so they can be followed. Adds three the original missed: collapsing the context barrel, getting every consumer onto one import path, and unpicking the dual-context test harness in render.tsx. Fixes a broken link to 15-risks-and-success.md.
  • 12-phase-6-duplicate-calls.md - records that this phase became an audit rather than the planned find-and-replace, what it turned up (one real duplicate in GridViewer), and the four lookalikes deliberately left alone.
  • 06 through 11 - each phase's success criteria checked off against the code.
  • 13-migration-checklist.md - phase 6 and 7 rows brought in line.
  • rfcs/README.md - regenerated by the pre-commit hook, since 086 is now the most recently modified RFC.

Three criteria are left unticked because they genuinely weren't met, each annotated with what happened instead:

  • Phase 1's "no console warnings" - a temporary log reporting which context is in use was added deliberately. Removing it is item 1 of IVR: Topics to review wellcomecollection.org#13273.
  • Phase 5's "restricted badge appears correctly" - there is no restricted badge in either tree. What isCurrentCanvasRestricted actually gates is hiding the download button on a restricted canvas.
  • Phase 6's "all components use currentCanvasIndex from context" - that value was deliberately never added to the context, since it would duplicate query.canvas.

Two more are left unticked because the code can't evidence them: phase 0's "all team members understand what types exist", and phase 3's optional manual testing checklist. Each phase's separate manual-testing checklist is also still unticked, for the same reason.

The eight documents that mention the old provisional names are otherwise left alone, as records of phases already delivered; the README table covers reading them.

How to test

Read it. All relative links resolve, and every ticket number was checked against the GitHub API.

Have we considered potential risks?

Docs only, nothing deployed. The risk runs the other way: phase 7 is the one part anyone still has to follow, so if its rewritten steps are wrong, someone hits that at cleanup time - worth a careful read of that file specifically. The counts in step 7.5 (32 files importing the context barrel, 16 importing refactored directly) are from today's main and will drift, so they're written as a grep to re-run rather than a number to trust.

Written by Claude Code.

Phases 0-6 have shipped, but the RFC still said "Status: Not started"
with every phase unticked. More importantly, the phase documents use
names the implementation never adopted - ItemViewerContextV2, the
.legacy.tsx/.refactored.tsx filename suffixes, and an
iiifViewerRefactored toggle - none of which appear in the codebase.
Phase 7 is the only phase still outstanding, and as written every path
in its mv/rm commands is fictional.

- README: status, progress ticked with ticket links, and a table
  translating the provisional names to the real ones
- Phase 7: steps rewritten against the real layout, plus three the
  original missed - collapsing the context barrel, consolidating the
  import paths, and unpicking the dual-context test harness
- Phase 6: records that it became an audit rather than the planned
  find-and-replace, and what that turned up
- Phases 0-5: success criteria checked off against the code, with the
  three that weren't met left unticked and annotated
- Migration checklist: phase 6 and 7 rows brought in line

The remaining documents that mention the old names are left alone, as
records of phases already delivered.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@rcantin-w
rcantin-w marked this pull request as ready for review September 16, 2026 08:04
@rcantin-w
rcantin-w requested review from a team as code owners September 16, 2026 08:04
@rcantin-w
rcantin-w requested review from davidpmccormick and removed request for a team September 16, 2026 08:05
@rcantin-w rcantin-w moved this from Backlog to Ready for review in Digital experience Sep 16, 2026

@davidpmccormick davidpmccormick left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat-oh!

Comment thread rfcs/086-item-viewer-refactor/README.md Outdated
- [x] Phase 2: Split MainViewer Components - [#12985](https://github.com/wellcomecollection/wellcomecollection.org/issues/12985)
- [x] Phase 3: Canvas Data (with automated tests) - [#12986](https://github.com/wellcomecollection/wellcomecollection.org/issues/12986)
- [x] Phase 4: Download Logic - [#12987](https://github.com/wellcomecollection/wellcomecollection.org/issues/12987)
- [x] Phase 5: Restriction Status - [#13412](https://github.com/wellcomecollection/wellcomecollection.org/pull/13412)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest linking to the issue (#12988) instead of the PR (#13412) for consistency?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot can you do that? (I've no idea I'm trying it)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in b6f0fc0 — phase 5 now links to issue #12988 instead of PR #13412.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It did it.

Co-authored-by: rcantin-w <110461050+rcantin-w@users.noreply.github.com>
@rcantin-w
rcantin-w merged commit cb2ffb8 into main Sep 16, 2026
7 checks passed
@rcantin-w
rcantin-w deleted the rfc-086-update-status-and-stale-instructions branch September 16, 2026 15:20
@rcantin-w rcantin-w moved this from Ready for review to Done in Digital experience Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants