Skip to content

fix: address the accessibility audit's first real findings #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weskcode merged 1 commit into from
Sep 8, 2026
Merged

fix: address the accessibility audit's first real findings #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions SunHat/Views/Components/SettingsIconLabel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,21 @@ struct SettingsIconLabel: View {
let systemImage: String
let color: Color

// A fixed-point icon frame stops scaling once the row's text grows with
// Dynamic Type, which the accessibility audit flags as "Dynamic Type
// font sizes are partially unsupported". @ScaledMetric ties the icon
// frame to the same text-size setting so it grows with the row.
@ScaledMetric(relativeTo: .body) private var iconDimension: CGFloat = 29
@ScaledMetric(relativeTo: .body) private var symbolSize: CGFloat = 14

var body: some View {
Label {
Text(title)
} icon: {
Image(systemName: systemImage)
.font(.system(size: 14, weight: .semibold))
.font(.system(size: symbolSize, weight: .semibold))
.foregroundStyle(.white)
.frame(width: 29, height: 29)
.frame(width: iconDimension, height: iconDimension)
.background(color.gradient, in: RoundedRectangle(cornerRadius: 6.5, style: .continuous))
}
}
Expand Down
2 changes: 1 addition & 1 deletion SunHat/Views/Reminders/AllRemindersView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ struct AllRemindersView: View {
.padding(.horizontal, 20)
.padding(.vertical, 10)
}
.buttonStyle(.glass)
.buttonStyle(.glassProminent)
.padding(.bottom, 20)
}
.sunHatSurface(tint: .accentColor, cornerRadius: 24, prominence: 0.70)
Expand Down
2 changes: 1 addition & 1 deletion SunHat/Views/Weather/WeatherView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ struct WeatherView: View {
} label: {
Text("Try Again", comment: "Retry button in the weather tab's unavailable state")
}
.buttonStyle(.glass)
.buttonStyle(.glassProminent)
}
.padding(.top, 60)
}
Expand Down