Let the model card workflow delete a card - #97
Merged
Merged
Conversation
The delete-model-card command only ran from the CLI, which needs the storage keys. The card endpoint now takes `delete: true` to run it on the server, and the Generate Model Card workflow gets a matching checkbox, so a card can be taken down without local credentials. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015roAwvpcszBvjX1Ce5NFuj
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Contributor
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
delete-model-cardcommand only ran from the CLI, which needs the storage keys locally. This lets the server run it, so a card can be taken down from GitHub.Changes
POST /api/internal/generate-model-cardacceptsdelete: trueand runsactionDeleteModelCard(pattern, { force: true })instead of generating. Auth and pattern validation are unchanged.deletecheckbox (default off).actionDeleteModelCardis now exported. Its behaviour is unchanged: it removeslive/models/cards/<pattern>.jsonand the local copy.Test plan
delete: truecalls the delete command and not the generator.tsc --noEmitis clean.pattern=apertus-v1.5-70banddeletechecked, then confirm/cards/apertus-v1.5-70breturns 404.Risks
The endpoint is auth-gated as before. Deleting a card only removes its JSON, and running the workflow without
deleteregenerates it.🤖 Generated with Claude Code
https://claude.ai/code/session_015roAwvpcszBvjX1Ce5NFuj
Generated by Claude Code