Rebuild summaries whenever the add-models box is ticked - #99
Merged
Merged
Conversation
The job only rebuilt the homepage, leaderboards and model summaries when it had added a model somewhere, so there was no way to republish them after runs changed by other means. Ticking rebuild_summaries now always rebuilds at the end, even when every blueprint was skipped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015roAwvpcszBvjX1Ce5NFuj
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Contributor
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The add-models job only rebuilt the homepage, leaderboards and model summaries when it had added a model to at least one blueprint. After runs changed in other ways, such as re-judging, there was no way to republish them from GitHub. Now, ticking
rebuild_summariesalways rebuilds at the end, even when every blueprint was skipped.Changes
src/app/api/internal/add-models-to-runs/route.ts: rebuild whenrebuildSummariesis set, regardless of how many blueprints were added.Test plan
tsc --noEmitis clean.rebuild_summariesticked, and check the logs show "Summaries rebuilt."Risks
Each workflow run with the box ticked (the default) now always spends a rebuild, about 15 minutes of server time, even when nothing changed.
🤖 Generated with Claude Code
https://claude.ai/code/session_015roAwvpcszBvjX1Ce5NFuj
Generated by Claude Code