Repository navigation
Fix Ctrl+T and audit all Light keyboard shortcuts (0.7.1) - #5
Merged
Merged
Conversation
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ctrl+T previously only marked a pending tab; no tab appeared until a passage loaded. Light 0.7.1 creates and saves an independent blank tab immediately, preserves duplicate chapter tabs and their scroll positions, and cancels stale passage requests when starting or closing the last tab.
The shortcut audit also fixes shifted settings digits, captured Enter/comma/period aliases, plus-key variants, and equivalent bindings that could create ambiguous Qt shortcuts. Tab actions yield during key capture and while the Verse of the Day surface is visible.
Validation: 101 service/source tests; 74 real Qt keyboard checks covering every in-app action, visible text-field focus, tab lifecycle/limits, settings sections, radio controls/volume, custom bindings, aliases, and capture/closed guards; QML lint; clean release startup/playback/shutdown; zero production dependency vulnerabilities. Existing compositor shortcut ownership/reload/collision tests remain passing. The Qt suite substitutes only the layer-shell window and HTTP transport and uses local silent audio; it does not modify desktop configuration or contact account services.
A dedicated Arch/Quickshell CI job now runs the keyboard suite against Omarchy UI modules pinned to a full upstream commit. The local full-validation command also includes it. The clean Qt 6.12 CI runtime also exposed a name collision with its new Color singleton; Light now qualifies Omarchy theme colors explicitly. Standard installation and the reviewed local authentication boundary remain unchanged.