Repository navigation
Show sign-in success and return to Light - #6
Merged
Merged
Conversation
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completing YouVersion sign-in updated the account successfully but left Light hidden behind a blank provider browser tab. Light 0.7.2 now reopens the Account page with its localized success message when a sign-in initiated in Light completes.
The focus change happens once for an active sign-in. Discovering an existing session, later authenticated status polls, and failed sign-ins do not reopen the panel or show success. Authentication and callback handling are unchanged; the provider browser tab can be closed afterward.
Validation: full local validation passed: 101 source/service tests, 77 real Qt checks (including completion, existing-session, and failed-sign-in regressions), QML lint with zero unverified warnings, and clean release startup, native-free audio playback, and shutdown. The user also confirmed the existing real YouVersion browser authorization/callback flow successfully signed out and back in on 0.7.1; this patch addresses the missing visible completion feedback.