Repository navigation
Give the lock screen robotOS's cover, say "screen lock", fill doc gaps - #62
Merged
Merged
Conversation
A pattern or password works as well as a PIN, so robotOS now says "screen lock": the recovery screen offers "Open with your screen lock", and the host settings notes match. INSTALL.md's setup, renamed "Lock it with a screen lock": - Lock after screen timeout: 5 minutes. Android offers no 15-minute option, and a shorter delay is safer. - Why "Power button instantly locks" must be off: robotOS's tap-to-sleep counts as a press of the R1's power button. - What device admin is used for and how to turn it off. - How to check the setup took (Host & devices' protection line). - The limits of a screen lock on a rooted R1 with an unlocked bootloader. HUB.md's protection paragraph matches. Release notes for 0.6.8.
The lock screen now shows the recovery cover at full glow: the robot mark on black, so swiping up to unlock looks like swiping the cover away. - LogoGlow.still() draws the cover as a bitmap at the screen's size. - LockScreenLook sets it as the lock and home wallpaper once per design version, so a wallpaper the owner picks later is never replaced. The service applies it in the background at start (SET_WALLPAPER). - Tests: applied once at the screen's size; the snapshot (lock-screen.png) is black at the edges with the orange glow above the mark.
windoze95
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #61 after setting a screen lock on a real R1, where the owner chose a pattern.
LogoGlow.still().LockScreenLooksets it as the lock and home wallpaper once per design version, so a wallpaper the owner picks later is never replaced.Checked on the R1, with the pattern set:
The locked-button check needs a physical press, because SELinux blocks injecting into the button's input device from adb.
389 Android tests pass, 2 new (lock look applied once; lock-screen snapshot). Lint has no new warnings. Robolectric's wallpaper shadow can't load on SDK 34, so the wallpaper setter is injectable for the test.