refactor: compose shared Wecom client and add subpath exports - #5
Open
witjs wants to merge 16 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Architecture refactor for the WeCom SDK client layer:
Before
User,Message,Agent, …) inheritedWecomWecom.setGlobal()or constructing many clients with duplicated configAfter
WecomModulecomposition: modules takeClientSource = Partial<WecomConfig> | Wecomand share oneWecominstanceRequestKernel: shared request/retry/error policy used byWecomand unauthenticated clients likeWebhookcreateClient/createScope: preferred factories for shared clients and multi-tenant scopes (no process-wide globals)Suite.corp/corpWecom/createCorpClientandHardware.device/deviceWecom/createDeviceClientfor typed corp/device helperspackage.jsonexports:wecom/user,wecom/message,wecom/client, … plus matchingtsdownentriesCompatibility
new User(config)/new Message(config)still workWecominstanceMessagesupports defaultagentId(override per send / payload)Wecom.setGlobal()remains but is deprecated in favor ofcreateClient/createScopeExamples
Test plan
pnpm install && pnpm typecheckpnpm test(unit + contract + types; mock fetch)createClientsharing (single token refresh across modules)new User(config)/new Message(wecom)compatibilityimport { User } from 'wecom/user'afterpnpm buildNotes
Pushed via GitHub MCP (
create_branch+push_files/create_or_update_file) because shell had no usableGH_TOKENforgit push. Branch tip may include multiple incremental commits rather than the single local4823fd7commit; content targets the local refactor tree.A few guide/API doc pages and large test files (
identity/modules/endpoints) may still need a follow-up sync if CI shows drift vs local/workspace/wecom.