Skip to content

tests: adapt test_long_hash and test_fips to wolfSSL FIPS v5.2.4 - #85

Merged
danielinux merged 1 commit into
wolfSSL:mainfrom
gasbytes:minor-updates-to-the-testsuite
Sep 30, 2026
Merged

danielinux merged 1 commit into
wolfSSL:mainfrom
gasbytes:minor-updates-to-the-testsuite

Conversation

@gasbytes

Copy link
Copy Markdown
Contributor

FIPS v5.2.4 caps total CMAC input at 2^32-1 bytes and allows 64-bit AES-GCM tags. Updated the tests appropriately.

@gasbytes
gasbytes requested a balanced review from Copilot September 29, 2026 20:04
@gasbytes gasbytes self-assigned this Sep 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

Review effort: Lite
Findings: 2 Medium severity · 1 Low severity

Open (3)
What changed in this PR

Updates wolfSSL wrapper tests to align with wolfSSL FIPS v5.2.4 constraints (CMAC max input length and AES-GCM tag length rules).

Changes:

  • Update expected AES-CMAC output vector in test_long_hash.c.
  • Adjust long CMAC test length to stay within the new FIPS input cap.
  • Update AES-GCM invalid tag-size test cases to reflect 64-bit tags now being allowed.
File Description
wolfssl-gnutls-wrapper/​tests/​test_long_hash.c Updates CMAC expected value and reduces CMAC input length by 1 byte to comply with FIPS v5.2.4 limit.
wolfssl-gnutls-wrapper/​tests/​test_fips.c Removes 64-bit tag length from “invalid” cases for AES-GCM to match updated FIPS behavior.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread wolfssl-gnutls-wrapper/tests/test_fips.c Outdated
Comment thread wolfssl-gnutls-wrapper/tests/test_long_hash.c
Comment thread wolfssl-gnutls-wrapper/tests/test_long_hash.c
@danielinux
danielinux merged commit ed00fcc into wolfSSL:main Sep 30, 2026
58 of 89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants