Repository navigation
tests: adapt test_long_hash and test_fips to wolfSSL FIPS v5.2.4 - #85
Merged
Merged
Conversation
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
Review effort: Lite
Findings: 2
Open (3)
The comment is now inconsistent with the test intent described in the PR: 64-bit (8-byte) tags are… · New Usingbuf_sz - 1is both opaque (it’s not clear to the reader which limit is being targeted) and… · New The CMAC expected bytes changed, but there’s no in-test explanation tying this vector to the… · New
What changed in this PR
Updates wolfSSL wrapper tests to align with wolfSSL FIPS v5.2.4 constraints (CMAC max input length and AES-GCM tag length rules).
Changes:
- Update expected AES-CMAC output vector in
test_long_hash.c. - Adjust long CMAC test length to stay within the new FIPS input cap.
- Update AES-GCM invalid tag-size test cases to reflect 64-bit tags now being allowed.
| File | Description |
|---|---|
| wolfssl-gnutls-wrapper/tests/test_long_hash.c | Updates CMAC expected value and reduces CMAC input length by 1 byte to comply with FIPS v5.2.4 limit. |
| wolfssl-gnutls-wrapper/tests/test_fips.c | Removes 64-bit tag length from “invalid” cases for AES-GCM to match updated FIPS behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
… input limit and 64-bit GCM tags
gasbytes
force-pushed
the
minor-updates-to-the-testsuite
branch
from
September 29, 2026 20:26
92ce009 to
be9133b
Compare
danielinux
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


FIPS v5.2.4 caps total CMAC input at 2^32-1 bytes and allows 64-bit AES-GCM tags. Updated the tests appropriately.