Skip to content

Add FDO client-sdk-fidoiot patch for wolfSSL - #365

Open
stenslae wants to merge 1 commit into
masterfrom
client-sdk-fidoiot-wolfssl
Open

stenslae wants to merge 1 commit into
masterfrom
client-sdk-fidoiot-wolfssl

Conversation

@stenslae

Copy link
Copy Markdown
Member

Adds client-sdk-fidoiot/, a patch that gives the FDO Client SDK a wolfSSL crypto/TLS backend and optional wolfTPM device attestation. Upstream is archived, so the patch
targets its last code commit, 40e5024 (2025-08-06).

Added:

  • wolfSSL backend (-DTLS=wolfssl): ECDSA P-256/P-384 signing and verification, ECDH KEX,
    SHA-2, HMAC, AES-GCM/CCM, the RNG, and curl over wolfSSL TLS.
  • wolfTPM option (-DTPM_STACK=wolftpm): device attestation through wolfTPM as an
    alternative to tpm2-tss.
  • Unit tests for the wolfSSL backend, plus .github/build_wolfssl_ci.sh to build and run
    the tests across configurations.
  • Build tooling: utils/install_wolfssl_curl.sh builds wolfSSL, curl and wolfTPM, and
    GPG-verifies the wolfSSL and curl tarballs. There is also a Dockerfile and a Jenkinsfile.
  • Yocto: a clientsdk-wolfssl recipe in utils/meta-intel-sdo.
  • Fixes to the existing code:
    • bounds checks on DER signature encoding and on peer-random parsing
    • validation of the peer's point in ECDH
    • correct byte order for the raw device key
    • AES IV rollover handling
    • freeing results from tpm2 NV calls

@stenslae stenslae self-assigned this Oct 12, 2026
Copilot AI balanced review requested due to automatic review settings October 12, 2026 17:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The testing instructions omit the required wolfTPM installation prerequisite.

1 open finding
What changed in this PR

Documents how to apply, build, test, and integrate the FDO wolfSSL/wolfTPM patch.

Changes:

  • Adds build and dependency setup instructions.
  • Documents testing, wolfTPM, and Yocto workflows.
File Description
client-sdk-fidoiot/​README.md Adds usage and integration documentation.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread client-sdk-fidoiot/README.md
@stenslae
stenslae force-pushed the client-sdk-fidoiot-wolfssl branch from 8da0d3f to 97d9771 Compare October 12, 2026 17:11
@stenslae
stenslae requested a balanced review from Copilot October 12, 2026 17:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The wolfTPM and Yocto instructions omit conditions needed for reproducible builds.

2 open findings
1 resolved since last review

🧠 Review effort: Balanced

Comment thread client-sdk-fidoiot/README.md Outdated
Comment thread client-sdk-fidoiot/README.md
@stenslae
stenslae requested review from wolfSSL-Fenrir-bot and removed request for wolfSSL-Fenrir-bot October 12, 2026 17:29
@stenslae
stenslae force-pushed the client-sdk-fidoiot-wolfssl branch from 97d9771 to b4dac50 Compare October 12, 2026 17:32
@stenslae
stenslae requested a balanced review from Copilot October 12, 2026 17:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The manual wolfTPM instructions use a prefix inconsistent with the documented CMake configuration.

1 open finding
2 resolved since last review

🧠 Review effort: Balanced

Comment thread client-sdk-fidoiot/README.md Outdated
Adds a wolfSSL crypto/TLS backend and optional wolfTPM attestation to
the archived FDO Client SDK, based on its final commit 40e5024.
@stenslae
stenslae force-pushed the client-sdk-fidoiot-wolfssl branch from b4dac50 to 88b9faa Compare October 12, 2026 18:10
@stenslae
stenslae requested a balanced review from Copilot October 12, 2026 18:12

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The documentation is consistent with the accompanying patch tooling and resolves the previously identified setup issues.

0 open findings

1 resolved since last review

🧠 Review effort: Balanced

@stenslae stenslae assigned wolfSSL-Bot and unassigned stenslae Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants