Repository navigation
Check AES-GCM size against wolfCrypt options - #37
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The PSA test excludes the valid rejection of a 12-byte tag when WOLFSSL_MIN_AUTH_TAG_SZ is set to 16, causing check_status() to fail instead of respecting the configured minimum.
1 open issue
What changed in this PR
This PR makes PSA AES-GCM tag validation respect wolfCrypt’s configured minimum authentication tag size.
Changes:
- Distinguishes invalid PSA tag lengths from valid lengths unsupported by wolfCrypt.
- Adds shortened-tag tests covering encryption, decryption, and unsupported-tag responses.
| File | Description |
|---|---|
test/psa_server/psa_api_test.c |
Adds and registers shortened GCM tag tests. |
src/psa_aead.c |
Enforces wolfCrypt’s minimum tag size and propagates the appropriate PSA error. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return error if GCM tag size is too big, based on wolfcrypt settings
Fixes F-10465