Skip to content

Define PSA_WANT_* macros as 1 for compatibility - #38

Merged
Frauschi merged 1 commit into
wolfSSL:masterfrom
padelsbach:want-values
Oct 29, 2026
Merged

Frauschi merged 1 commit into
wolfSSL:masterfrom
padelsbach:want-values

Conversation

@padelsbach

@padelsbach padelsbach commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Set defines PSA_WANT_ALG_SHA_1 etc to 1 for use cases such as curl:

Example: lib/vtls/mbedtls.c:

#if defined(PSA_WANT_ALG_SHA_256) && PSA_WANT_ALG_SHA_256
  status = psa_hash_compute(PSA_ALG_SHA_256, ...);
#else
  return Curl_sha256it(sha256sum, input, inputlen);
#endif

... and a couple others.

Copilot AI balanced review requested due to automatic review settings October 28, 2026 23:55
@padelsbach
padelsbach requested a review from Frauschi October 28, 2026 23:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the change giving standalone-build PSA feature macros numeric values.

No open issues 🎉

What changed in this PR

This PR makes standalone-build PSA feature macros compatible with consumers such as curl that check their numeric values in preprocessor conditions.

Changes:

  • Defines the SHA, RSA key-type, ML-DSA, and ML-KEM PSA_WANT_* macros as 1 instead of leaving their values empty.
  • Preserves the existing set of enabled features.
File Description
wolfpsa/​psa/​crypto_config.h Assigns numeric values to standalone-build PSA feature macros.

Review effort: Balanced

@Frauschi
Frauschi merged commit 2e051cc into wolfSSL:master Oct 29, 2026
88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants