Repository navigation
Define PSA_WANT_* macros as 1 for compatibility - #38
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the change giving standalone-build PSA feature macros numeric values.
No open issues 🎉
What changed in this PR
This PR makes standalone-build PSA feature macros compatible with consumers such as curl that check their numeric values in preprocessor conditions.
Changes:
- Defines the SHA, RSA key-type, ML-DSA, and ML-KEM
PSA_WANT_*macros as1instead of leaving their values empty. - Preserves the existing set of enabled features.
| File | Description |
|---|---|
wolfpsa/psa/crypto_config.h |
Assigns numeric values to standalone-build PSA feature macros. |
Review effort: Balanced
Frauschi
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set defines
PSA_WANT_ALG_SHA_1etc to 1 for use cases such ascurl:Example:
lib/vtls/mbedtls.c:... and a couple others.