Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
amd_eth_init()previously blocked for up to 10 seconds waiting for copper link establishment (GEM_PHY_ANEG_TIMEOUT_MS+GEM_PHY_LINK_TIMEOUT_MS), preventing callers from running initialization in parallel.Key Changes
0now triggers auto-negotiation and returns immediately. Callers poll viagem_link_resolve()to handle MAC programming and speed/duplex resolution asynchronously.BMSR_ANCOMPLETEcheck before resolving link parameters. Prevents early reads from transient PHY registers (e.g., TI DP83867PHYSTSdefaulting to 10M/HD) from corrupting MAC and reference clock settings.gem_link_resolve()to overwrite the entire MAC speed/duplex register field rather than bitwise clearing, ensuring idempotency across multiple resolutions.Hardware / Test Status
0.amd_eth_init()returned immediately while negotiation ran in background. Link resolved ~3.1s later at 1000 Mbps Full Duplex with successful ICMP ping responses.zcu102,zynq7000, andversal.