Repository navigation
Tighten chain certificate handling in WolfSSLTrustX509 - #443
Conversation
…ts as issuers in certManagerVerify
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #443
Scan targets checked: wolfssljni-src, wolfssljni-bugs
Coverage: 1 of 3 in-scope changed file(s) opened by the reviewer; not opened: src/test/com/wolfssl/provider/jsse/test/WolfSSLTestFactory.java, src/test/com/wolfssl/provider/jsse/test/WolfSSLTrustX509Test.java
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
Review tier: Lite
Dismissing following the reasoning of @cconlon, see reply to Fenrir finding:
"This exception is intentional and keeps the existing trusted peer cert behavior from PR #154. With WOLFSSL_TRUST_PEER_CERT enabled, CertManagerLoadCAKeyStore already loads every KeyStore entry into the CertManager at init regardless of cA, so a non-CA store entry can sign leaves whether or not the peer resends it in the chain. The suggested sortedCerts[0] check would reject the chain only when the entry is resent and still accept the same leaf sent alone."
This PR includes one Fenrir fix:
certManagerVerifyloads chain certificates as issuers, with tests.