Skip to content

Tighten chain certificate handling in WolfSSLTrustX509 - #443

Merged
rlm2002 merged 1 commit into
wolfSSL:masterfrom
cconlon:fenrirOct20_2
Oct 26, 2026
Merged

rlm2002 merged 1 commit into
wolfSSL:masterfrom
cconlon:fenrirOct20_2

Conversation

@cconlon

@cconlon cconlon commented Oct 21, 2026

Copy link
Copy Markdown
Member

This PR includes one Fenrir fix:

  • F-15740: Check certificate extensions before certManagerVerify loads chain certificates as issuers, with tests.

@cconlon cconlon self-assigned this Oct 21, 2026
Copilot AI balanced review requested due to automatic review settings October 21, 2026 21:19

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #443

Scan targets checked: wolfssljni-src, wolfssljni-bugs
Coverage: 1 of 3 in-scope changed file(s) opened by the reviewer; not opened: src/test/com/wolfssl/provider/jsse/test/WolfSSLTestFactory.java, src/test/com/wolfssl/provider/jsse/test/WolfSSLTrustX509Test.java

Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Reported findings require changes before merge.

Review tier: Lite

@cconlon cconlon assigned rlm2002 and unassigned cconlon Oct 22, 2026
@rlm2002
rlm2002 dismissed wolfSSL-Fenrir-bot’s stale review October 26, 2026 17:43

Dismissing following the reasoning of @cconlon, see reply to Fenrir finding:

"This exception is intentional and keeps the existing trusted peer cert behavior from PR #154. With WOLFSSL_TRUST_PEER_CERT enabled, CertManagerLoadCAKeyStore already loads every KeyStore entry into the CertManager at init regardless of cA, so a non-CA store entry can sign leaves whether or not the peer resends it in the chain. The suggested sortedCerts[0] check would reject the chain only when the entry is resent and still accept the same leaf sent alone."

@rlm2002
rlm2002 merged commit f64c140 into wolfSSL:master Oct 26, 2026
109 of 110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants