chore: migrate build to Stars CLI - #107
Conversation
◈ PR Lens
Architecture 7 components touched across 4 lanes. Play the interactive walkthrough Inside the changed components — 2 viewsComponent view — Server runtime & initialization HTTP server startup sequence, framework v5 migration, and integrated plugin setup Component view — Build toolchain & bundling Migration from custom tsdown configuration to stars CLI with path alias resolution Data flow
Follow each request, response and payload View
Tip Run 🪧 More tips
Thanks for using PR Lens! It's built by Coldtea, free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
| defaultNS: "globals", | ||
| defaultMissingKey: "globals:default", |
There was a problem hiding this comment.
defaultNS and defaultMissingKey both reference globals, but the locale tree only supplies commands/shared. A missing translation therefore resolves to the literal default key fragment rather than the intended diagnostic message. Add globals:default to the locale resources or configure an existing translated fallback. This is non-blocking, but it makes missing translations harder to diagnose.
Artifacts
Missing-key fallback validation script
- The authored script loads the real locale tree in an isolated temporary directory and formats one missing key under each configuration; it is the executed source.
Current globals fallback output
- The current `globals` configuration discovers only `commands/shared` and resolves the missing key to `default`, proving the configured fallback is unavailable.
Existing namespace control output
- The control using the existing `commands/shared` namespace resolves the same missing key to its configured translation, showing the fallback mechanism works when the resource exists.
Ran code and verified through T-Rex
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/main.ts
Line: 23-24
Comment:
**Point fallback at locale**
`defaultNS` and `defaultMissingKey` both reference `globals`, but the locale tree only supplies `commands/shared`. A missing translation therefore resolves to the literal `default` key fragment rather than the intended diagnostic message. Add `globals:default` to the locale resources or configure an existing translated fallback. This is non-blocking, but it makes missing translations harder to diagnose.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Bump @wolfstar/http-framework to 4.0.2 (and the workspace override pinning it), plus the rest of the @wolfstar/* packages, Prisma, discord-api-types, eslint tooling, oxlint/oxfmt, and other dev dependencies to their latest versions allowed by the repo's minimum-release-age supply-chain policy. Verified pnpm build and pnpm lint still pass. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FNVDCgACzS2u25z8fGC9zw
Sync the Dockerfile with wolfstar-project/staryl: bump the syntax directive to 1.27, document why the base stage must not be pinned to $BUILDPLATFORM, drop the redundant --frozen-lockfile flag on `pnpm fetch` (already the default), and note that pnpm 12 may auto-install at container startup. Bump packageManager to pnpm@12.4.2; verified pnpm install, build and lint all pass under the new version. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FNVDCgACzS2u25z8fGC9zw
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
Follow https://stars-components.js.org/guide/migration.md to move to @wolfstar/http-framework@5.0.0 and @wolfstar/cli@1.0.0. No source changes were required: this codebase already calls client.listen() directly (never used the removed createFetchHandler/FetchHandler from http-framework/fetch) and never caught ConfigError/CliError, and stars.config.ts's shape is unaffected by the migration. Both packages were published same-day, so they're explicitly excluded from the minimumReleaseAge supply-chain policy in pnpm-workspace.yaml (accepted risk, per explicit instruction) alongside bumping the @wolfstar/http-framework override to ^5.0.0. Verified pnpm install, prisma:generate, build and lint all pass. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FNVDCgACzS2u25z8fGC9zw
Summary
@wolfstar/cli0.6.0stars.config.ts@wolfstar/plugin-i18nextand@wolfstar/plugin-logger@wolfstar/plugin-*/registerside-effect injectionVerification
pnpm lintpnpm prisma:generatepnpm buildMerge-safe. The only remaining concern is non-blocking and does not make the change unsafe to merge.
Reviews (4) · Last reviewed commit: "chore(deps): migrate to http-framework v..."