Repository navigation
fix(openai): honour a pinned temperature, warn when dropped; add gpt-6.1-sol - #1000
Merged
Merged
Conversation
An unconfigured reasoning model now defaults to effort medium, which made Responses drop a pinned temperature silently. Where the model allows effort none and none is configured, keep reasoning off so the temperature is sent; otherwise warn once per model when it is dropped. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TzDPzEBWQ9BxV7Pwfo5Db7
…ath to GPT-5.6 Prices for gpt-6.1-sol come from OpenAI's published pricing page. A pinned temperature keeps reasoning off only on gpt-5.6 models; every other reasoning model drops it with a warning instead of sending an effort that may 400. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TzDPzEBWQ9BxV7Pwfo5Db7
Collaborator
Author
|
The Generated by Claude Code |
…warning Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TzDPzEBWQ9BxV7Pwfo5Db7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
finalizeResponsesRequestdeletedparams.temperaturewheneverreasoning.effort !== "none". Since unconfigured reasoning models default to effortmedium, a caller pinningtemperature: 0had it silently ignored.Change
none; class policy andeffort_optionsmust allow it): sendreasoning.effort: "none"and keep the temperature.warnTemperatureDroppedOnce).none, however the record asks for it.gpt-6.1-solto the fallback model list and pricing (short $2 / cached $0.10 / cache-write $2.50 / output $10; long-context tier derived as 2x/1.5x, which matches the published long row). It resolves to the gpt-6 effort policy (low..max, nonone).Tests
Tests are added for gpt-5.6 (kept), gpt-6 and gpt-6.1-sol, gpt-5.5, o3, gpt-4o, and for gpt-6.1-sol pricing and effort policy. 153 tests pass across the 9 affected files.
bun run formatandbun run format-checkare clean and touched no unrelated files.Not verified
OpenAI's docs page did not state which models reject temperature or top_p, so that behaviour is unchanged for every model except the gpt-5.6 path above.
🤖 Generated with Claude Code
https://claude.ai/code/session_01TzDPzEBWQ9BxV7Pwfo5Db7