Repository navigation
Post-GKR sumcheck - #69
Merged
Merged
Conversation
# Conflicts: # README.md
frozenspider
marked this pull request as draft
September 17, 2026 09:35
frozenspider
force-pushed
the
fs/post-gkr-sc-v4
branch
from
September 17, 2026 13:11
bae9fdb to
3c09732
Compare
frozenspider
marked this pull request as ready for review
September 17, 2026 14:57
This was referenced Sep 24, 2026
shreyas-londhe
requested changes
Sep 29, 2026
Collaborator
Author
|
Thanks for the review @shreyas-londhe! Applied both changes. |
shreyas-londhe
approved these changes
Sep 30, 2026
shreyas-londhe
left a comment
shreyas-londhe
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thanks for the PR @frozenspider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a degree-2 sumcheck between GKR and PCS, reducing GKR inner product claim to an MLE evaluation claim, replacing placeholder sumcheck in
pcscrate.This change results in end-to-end verifier being ~20% faster in the
routine on my machine.
Additional notable changes:
VirtualStatement::transpose_query.F128::to_u128(), reconstructing it seems to be a recurring pattern.