Nikola theme update and fixes - #11
Conversation
|
It’s kinda hard to review a PR mixing multiple of different things, but at least you provide a live version to observe it working |
echoix
left a comment
There was a problem hiding this comment.
I have a couple questions and assumptions to verify
| * Zip files with `*.pdb` files which are Visual Studio debugger information files. | ||
|
|
||
| * Binary wheel files for a few flavors of **Linux**. | ||
| * Binary wheel files for a few flavours of **Linux**. |
There was a problem hiding this comment.
Before it was using US spelling, now it is UK/Canada/Australian spelling
| # environment but is not recommended for HTTP/2.0 when caching is used. | ||
| # Defaults to True. | ||
| USE_BUNDLES = not USE_TEST_SITE | ||
| # !This seems to brake boostrap v5 |
| # It can be anything, data, functions, modules, etc. | ||
| GLOBAL_CONTEXT = { | ||
| 'header_logo': '<img src="/images/header-logo.png" />' | ||
| 'example': '/images/header-logo.png' |
There was a problem hiding this comment.
I might understand later in the review, but is "example" expected here?
There was a problem hiding this comment.
Nikola has a dedicated variable LOGO_URL that is now used.
I just left a dummy entry in GLOBAL_CONTEXT
| <!-- | ||
| .. title: Welcome to wxPython! | ||
| .. slug: index | ||
| .. tags: | ||
| .. link: | ||
| .. description: All about wxPython, the cross-platform GUI toolkit for the Python language | ||
| --> |
There was a problem hiding this comment.
This is usually yaml, it is called "front-matter", where you add some metadata that the website builder uses when creating html pages from markdown. I often see it with a separator after the end of that section.
There was a problem hiding this comment.
Nikola supports a variety of styles for front matter. This style is consistent with that of every other file in this folder.
| experiences, etc. All questions that are Python specific should be asked here.<br> | ||
| [Mail Address](mailto:wxpython-users@googlegroups.com), | ||
| [Group URL](http://groups.google.com/group/wxpython-users) | ||
| [Group URL](https://groups.google.com/group/wxpython-users) |
There was a problem hiding this comment.
I assume here, and for all other http->https changes in this PR, that you tested that the server responds correctly. I still see some that don't work with https, which is another kind of problem.
There was a problem hiding this comment.
Yes, i mainly checked for dead links but also changed them to https in case they redirected.
There was a problem hiding this comment.
Usually, for screenshots (especially text), jpeg isn’t used because of the loss in quality of text and graphics. The gif used was an option that would be lossless if it fit in the palette restrictions, but there’s also .png that can be lossless and we often see in screenshots.
This applies to the multiple recompressed into jpeg files that are screenshots.
There was a problem hiding this comment.
Websites usually care alot about filesizes. But I agree, in this case the lossless files should be kept.
| ## | ||
| ## A shortcode template to add a book to the bookshelf | ||
| ## | ||
| ## Expected Parameters: | ||
| ## asin: number of book | ||
| ## title: title of book | ||
| ## img: path to the bookcover | ||
| ## |
There was a problem hiding this comment.
What file type (syntax) does tmpl files use? (To make sure lines starting with # are parsed as comments)
There was a problem hiding this comment.
Nikola uses the mako template engine, in this case.
single line comment, two ##:
## this is a comment.
multi line comment:
<%doc>
these are comments
more comments
</%doc>
| @@ -1,54 +1,159 @@ | |||
| /* | |||
| * wxPython specific overrides for style items in the base and bootstrap3 themes. | |||
| * wxPython specific overrides for style items in the base and bootstrap4 themes. | |||
There was a problem hiding this comment.
Nikola provides a base-theme that uses bootstrap 4. The custom wxPython theme (now) overwrites it with bootstrap 5.
| [Theme] | ||
| engine = mako | ||
| parent = bootstrap3 | ||
| parent = bootstrap4 |
There was a problem hiding this comment.
Nikola provides a base-theme that uses bootstrap 4. The custom wxPython theme (now) overwrites it with bootstrap 5.
|
|
||
| # Name of the theme to use. | ||
| #THEME = "bootstrap3" | ||
| #THEME = "bootstrap4" |
There was a problem hiding this comment.
Nikola provides a base-theme that uses bootstrap 4. The custom wxPython theme (now) overwrites it with bootstrap 5.
I see. I can split it into smaller PR, if you like, Just didn't want to spam you. |
|
I reverted the changed screenshots and the changed the two words back to US spelling. The incorrect comment in |
Hello,
I updated the nikola theme to bootstrap v5 so that the page renders well and looks nice.
This is how the updated version looks like: https://wxpyweb-test.netlify.app
Hopefully this is helpful and please let me know if there are any other changes you would like to have implemented.