Add CI for phoenix/ (Python tests + Rust workspace check) - #74
Open
AnonRish wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
phoenix/, the one componentdocumented as buildable outside X's internal infrastructure
python-tests:uv sync --group dev+pytestover xrexrust-check: installs the workspace's declared MSRV, the documentedsystem packages, and protoc, then
cargo check --workspace --all-targetsand
cargo test --workspaceProblem
No GitHub Actions workflow exists anywhere in this repository. Every
currently open PR is relying entirely on manual review with no automated
signal.
Fix
A minimal, two-job workflow triggered on changes under
phoenix/:python-testsruns the pure-Python surface only (no Rust toolchainrequired), keeping it fast and independent of the Rust build.
rust-checkpins rustc 1.85 explicitly (this workspace's declaredminimum, not whatever the runner ships today) and installs the same
system packages and protoc version documented in the README.
home-mixerand the other services are intentionally excluded: none ofthem has a standalone Cargo.toml or build manifest in this repository, and
they import internal-only packages, so there's nothing yet for a public
runner to build.
cargo fmt --checkandclippyare also deliberatelyexcluded from this PR -- unclear whether existing code is clean against
either, and a first CI PR shouldn't open red against pre-existing code;
both are reasonable fast-follows once this is green.
Verification
python -c "import yaml; yaml.safe_load(open(...))".python-testscommands run end to end:uv sync --group dev && uv run pytestpasses 17/17 against the suite added in the companion tests PR.rust-checkcould not be run locally (no rustc >=1.85 reachable in thisenvironment); the system-package list and protoc invocation are copied
from what's already verified working in phoenix/README.md's own
instructions, corrected to linux-x86_64 for this runner's architecture.
Please confirm the
rust-checkjob goes green before merging, or flagfrom CI logs if it doesn't -- happy to iterate.