Recover Owned Coins pagination after coin combines - #810
Draft
joshpainter wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #809
Summary
Why
Combining coins can remove enough entries that the page the user was viewing no longer exists. The existing COUNT(*) OVER() total is only available when the paginated query returns at least one row; an empty out-of-range page therefore looked like a zero-coin list, and the UI had no reliable last-page value.
The extra COUNT(*) query runs only when the requested page is empty. It reuses the same asset filter to recover the exact total for that exceptional case, while normal page loads keep the existing single-query path. This lets the UI move to the last valid page without adding work to ordinary refreshes.
Validation
No new dependencies or tests were added.