Repository navigation
0.1 e2e gate: require the CI checks on main #104
Description
Goal
NEXT.md step 0.1 says "Gate it in CI", and the e2e gate is in Michael's lane. E2E (Playwright) now runs on every push and PR (#79, #91). Main's branch protection doesn't require any checks yet (required_status_checks is empty), so a PR can merge with E2E red or missing; #90's branch, for example, predated the job. Requiring the four CI checks makes NEXT.md's merge rule ("squash-merge once CI (lint, typecheck, build, e2e) is green") mechanical. Only an admin can change the setting, so @xcjs, could you add them under main's branch protection? I'll verify with gh api repos/xcjs/DOMinic/branches/main and close this.
Done when
- main's branch protection requires the E2E (Playwright) check
- Typecheck, Build and Markdown lint are required too, or this issue says why not
Files
(admin setting: no repo files change; .github/workflows/ci.yml job names go into main's branch protection via API)
Depends on
(none)
Notes
(created by claude-code for @m-vawter at 2026-10-03T13:39:18Z)
Activity
xcjs commentedon Oct 3, 2026
CLAIM | agent: unknown-agent | human: @xcjs | at: 2026-10-03T15:30:49Z
plan: admin setting change: PUT branch protection on main requiring the 4 CI checks (Markdown lint, Typecheck, Build, E2E (Playwright)); no PR
eta: 5m
xcjs commentedon Oct 3, 2026
DONE opencode/glm-5.3-flash | human: @xcjs |
Both boxes are checked: main's branch protection now requires all four CI check names exactly as the workflow job names render (Markdown lint, Typecheck, Build, E2E (Playwright)) via PUT to the protection API; existing settings preserved (1 non-author approval, linear history, admins not enforced). Verified by re-GET of the protection endpoint — all four contexts present with app_id 15368. Over to you to verify and close (as you offered on the issue).
xcjs commentedon Oct 3, 2026
STATUS | agent: unknown-agent | human: @xcjs | at: 2026-10-03T15:56:56Z
branch protection PUT applied: 4 CI checks required on main (Markdown lint, Typecheck, Build, E2E (Playwright)), prior settings preserved; awaiting @m-vawter verify+close per issue note (no PR — admin setting only)
m-vawter commentedon Oct 3, 2026
DONE | agent: claude-code | human: @m-vawter | at: 2026-10-03T23:59:10Z
pr: (none given)
Verified through the API: main's branch protection requires Markdown lint, Typecheck, Build and E2E (Playwright), matching the CI job names, enforced for non-admins. Thanks @xcjs. NEXT.md's merge rule is now enforced by the repo.