Skip to content

Ask Agent to Fix does nothing when Agent Chat is closed #92

Closed

Description

@m-vawter

Goal

"Ask Agent to Fix" does nothing when Agent Chat is closed. askFix in app/app.vue calls openBuiltin('chat'), but chat.value is still null in the same tick, so chat.value?.sendMessage(...) is skipped silently.

Repro: close Agent Chat, break an app (window.__dominic.injectBrokenApp('compile')), click Ask Agent to Fix. The chat reopens, but no request reaches /api/chat and no message appears (confirmed with a throwaway Playwright spec while building #91).

Fix idea: await nextTick() after openBuiltin before sending, or queue the message until the chat mounts. An e2e case in the #91 suite can cover it.

Justin is not active right now, so @m-vawter's agent is taking this one; the integration lane is otherwise unchanged.

Done when

  • Ask Agent to Fix reaches the agent when Agent Chat was closed
  • an e2e case covers it

Files

app/app.vue,tests/e2e/ask-fix-chat-closed.spec.ts

Depends on

(none)

Notes

(created by claude-code for @m-vawter at 2026-10-03T00:52:24Z)

Activity

  1. added
    ws:integrationIntegration lane - app.vue wiring, product loop, polish
    p1Important, not on the critical path
    type:bugSomething broken
    on Oct 3, 2026
  2. m-vawter commented on Oct 3, 2026

    @m-vawter
    CollaboratorAuthor

    CLAIM | agent: claude-code | human: @m-vawter | at: 2026-10-03T00:54:30Z

    plan: branch: fix/ask-fix-when-chat-closed, stacked on #91 so the e2e suite covers it. Wait for the chat to mount before sending (nextTick), plus an e2e case in its own spec: close Agent Chat, break an app, Ask Agent to Fix -> the stubbed agent repairs it.
    eta: 2h

  3. self-assigned this
    on Oct 3, 2026
  4. added and removed on Oct 3, 2026
  5. m-vawter commented on Oct 3, 2026

    @m-vawter
    CollaboratorAuthor

    REVIEW | agent: claude-code | human: @m-vawter | at: 2026-10-03T00:57:20Z

    pr: #93

  6. added and removed on Oct 3, 2026
  7. m-vawter commented on Oct 3, 2026

    @m-vawter
    CollaboratorAuthor

    DONE | agent: claude-code | human: @m-vawter | at: 2026-10-03T12:32:30Z

    pr: #95
    Fix merged in #95 (squash). Ask Agent to Fix now reaches the agent when Agent Chat was closed, and tests/e2e/ask-fix-chat-closed.spec.ts covers it. Main is green on 7138156.

  8. xcjs commented on Oct 3, 2026

    @xcjs
    Owner

    DONE | agent: unknown-agent | human: @xcjs | at: 2026-10-03T13:04:06Z

    pr: #95
    PR #95 merged (rescued re-open of auto-closed #93); both Done-when boxes checked in the issue body; ask-fix e2e present in the merged suite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

p1Important, not on the critical pathstatus:in-reviewPR open, needs reviewtype:bugSomething brokenws:integrationIntegration lane - app.vue wiring, product loop, polish

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions