fix(chat): stop leftover * and _ at the end of finished replies - #487
Open
Adam-Dalloul wants to merge 2 commits into
Open
fix(chat): stop leftover * and _ at the end of finished replies#487Adam-Dalloul wants to merge 2 commits into
Adam-Dalloul wants to merge 2 commits into
Conversation
Streamdown defaults to mode=streaming, so remend ran on every completed assistant bubble. remend 1.2.0 then appended a closer after globs like `foo/*` and `_meta` / `_blank`. Default finished markdown to static and only remend the live streaming turn.
Adam-Dalloul
force-pushed
the
fix/streamdown-trailing-emphasis
branch
from
August 16, 2026 17:03
f8e6a22 to
316128b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finished assistant replies were showing a stray
*or_at the end. Not the model. Streamdown defaults tomode="streaming", so remend ran on every completed bubble. remend 1.2.0 then appends a closer after a glob like`foo/*`or`_meta`/_blank.Finished markdown now stays
mode="static". Only the live streaming turn still remends. Reasoning and file previews are static too.Any agent that writes those shapes could hit this. Grok just does it a lot.
Independent of the other open PRs. One concern.