add log on nesting feature - #184
Merged
Merged
Conversation
yanganto
force-pushed
the
log-nesting
branch
3 times, most recently
from
September 12, 2026 03:11
4f8d5f5 to
4b0ea0b
Compare
yanganto
marked this pull request as ready for review
September 12, 2026 05:11
yanganto
force-pushed
the
log-nesting
branch
2 times, most recently
from
September 12, 2026 06:13
856bd21 to
fb6d54d
Compare
yanganto
force-pushed
the
log-nesting
branch
from
September 12, 2026 06:23
fb6d54d to
8a01db6
Compare
kp-mariappan-ramasamy
added a commit
to expressvpn/lightway
that referenced
this pull request
Sep 15, 2026
struct-patch 0.14.2 leaks `#[cfg(feature = "nesting")]` attributes into the
code generated by the `Patch` derive. Those cfgs are evaluated against the
consuming crate's features rather than struct-patch's own, so lightway-client
(which has no `nesting` feature) trips rustc's `unexpected_cfgs` lint:
error: unexpected `cfg` condition value: `nesting`
--> lightway-client/src/config.rs:30:71
Under `-D warnings` this is a hard failure, which broke the lint, Windows,
Nix test and mobile CI jobs. Enabling struct-patch's `nesting` feature does
not help, since the cfg resolves in the downstream crate.
Drop the pin once a fixed release is published.
Upstream issue: yanganto/struct-patch#185
Introduced by: yanganto/struct-patch#184
Changes: yanganto/struct-patch@v0.14.1...v0.14.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.