Repository navigation
Update dependencies; lock json 3, keep json 2 covered in CI - #9
Merged
Merged
Conversation
Cargo: magnus 0.9.3, memmap2 0.9.12 and transitive patch releases, all within the existing ranges. Gems: ActiveSupport/ActionPack 8.1.4, standard 1.57 (rubocop 1.91), oj, lefthook and others; rubocop 1.92, prism 2 and diff-lcs 2 stay held back by standard's and rspec's pins. actions/checkout moves to v7 (its fork-PR block only affects pull_request_target and workflow_run, which no workflow here uses). standard 1.57's rubocop accepts json 3, so the lockfile now resolves json 3.1 and the main matrix runs it. The json-compat job flips to pin json < 3, spelled like the rails-compat pins, to keep the drop-in's json 2 branch covered. A pinned run no longer needs to leave standard out, so the Gemfile and Rakefile drop that workaround, and the Gemfile requires standard 1.57 so json 3 stays resolvable.
yaroslav
force-pushed
the
update-deps-oct-26
branch
from
October 23, 2026 21:19
a4df7db to
b8fb5be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cargo: magnus 0.9.3, memmap2 0.9.12 and transitive patch releases, all within the existing ranges. Gems: ActiveSupport/ActionPack 8.1.4, standard 1.57 (rubocop 1.91), oj, lefthook and others; rubocop 1.92, prism 2 and diff-lcs 2 stay held back by standard's and rspec's pins. actions/checkout moves to v7 (its fork-PR block only affects pull_request_target and workflow_run, which no workflow here uses).
standard 1.57's rubocop accepts json 3, so the lockfile now resolves json 3.1 and the main matrix runs it. The json-compat job flips to pin json ~> 2.0 to keep the drop-in's json 2 branch covered, and a pinned run no longer needs to leave standard out, so the Gemfile and Rakefile drop that workaround. rails-compat pins json 2 too: stock ActiveSupport 7.1 and 8.0 pass quirks_mode to JSON.generate, which json 3 rejects, so they cannot encode on it with or without nosj.