Support TablePathPrefix and namespaced tables - #43
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
==========================================
+ Coverage 88.44% 88.69% +0.25%
==========================================
Files 58 59 +1
Lines 10115 10237 +122
==========================================
+ Hits 8946 9080 +134
+ Misses 668 662 -6
+ Partials 501 495 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
AI Review SummaryVerdict: ✅ No critical issues found Critical issuesNo critical issues found. Other findings
This review was generated automatically. Critical issues require attention; other findings are advisory. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Queries and schema files using
PRAGMA TablePathPrefixpreviously failed analysis, and tables with the same basename in different directories could not be represented consistently. This change resolves their physical paths during analysis and preserves the authored SQL, so generated queries can address independent tables in separate directories.Closes #29.
Behavior
PRAGMA TablePathPrefixper named query or schema file. Resolve relative table references consistently in schema DDL, reads, writes, index views, and connectedDescribeTablediscovery; absolute references bypass the prefix.SELECT records.id FROM records AS r, accepted by v0.2.4, must user.idto match YDB. Column bindings preserve case-sensitive aliases such asrandR; the compatibility guide and changelog document the migration.RenderMappingreplacements.Validation
make generateandmake checkpassed, with focused analyzer/model/generator regressions and SDK-backed jOOQ tests.ydbplatform/local-ydb:26.3.1.16: offline/connected schema parity and drift checks, generated Go native/database/sql and jOOQ execution, index views, absolute-path bypass, SELECT-backed writes, and namespace examples.339835cd, including stable/nightly YDB and the SDK checks. The combined Codecov report covers every modified coverable line and reports 88.69% project coverage.