Support shared YQL expressions and implicit SELECT names - #44
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
==========================================
+ Coverage 88.55% 89.47% +0.92%
==========================================
Files 59 63 +4
Lines 10237 10480 +243
==========================================
+ Hits 9065 9377 +312
+ Misses 675 631 -44
+ Partials 497 472 -25
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
![robot-vibe-db[bot]](https://avatars.githubusercontent.com/in/3319454?s=60&v=4){kind=small}
AI Review SummaryVerdict: ✅ No critical issues found Critical issuesNo critical issues found. Other findings
The rest of the changes were reviewed without further actionable findings: shared YQL expression resolution (Boolean operators, comparisons, null checks, concatenation), implicit This review was generated automatically. Critical issues require attention; other findings are advisory. |
|
Analysis performed by claude, z-ai/glm-5.3-flash. |
|
Analysis performed by claude, z-ai/glm-5.3-flash. |
2 participants
Reporting and filtering queries such as
COUNT_IF(bio IS NOT NULL),CAST(COUNT(*) AS Bool), andname LIKE $prefix || "%"unow share the same typed expression rules as supported DML assignments. Computed SELECT outputs withoutASreceive YDB-compatible names and result ordering, including collisions and wildcard expansion.Closes #31.
Validation passed:
make check, the complete Java generator suite with published SDK checks, the jOOQ examples Maven suite, strict TypeScript example compilation/build/import checks, the Rust SDK regression suite, andcargo test --lockedfor all Rust examples. Sequential execution against local YDB 26.3.1.16 passed through Go native, Go database/sql and Java jOOQ. The new live suite checks result metadata, NULL/empty aggregate behavior, narrowing and invalid-JSON boundaries, implicit names and wildcard normalization; CI runs it on stable and nightly images and includes its integration coverage.All nine CI checks passed on
62089386. The final merged Codecov report covers every modified executable line (100% patch coverage) and reports 89.47% project line coverage, up from 88.55% on its coverage-bearing base9f1a0af. Regression tests cover predicate diagnostics, wildcard/collision ordering and typed jOOQ output-alias sorting; stable CI executes the Go and jOOQ checks against YDB. Codecov line coverage is distinct from local Go statement coverage.Implicit-name and type rules were checked against YDB source at
1415fed8104201c5e973dd8bbf12c71c6b1ed8b9; exact source and SDK evidence is recorded in the contributor documentation. Unsupported overloads and runtime result types retain actionable diagnostics.