perf(guest): read the private input zero-copy via ef_io::read_input - #886
Draft
diegokingston wants to merge 2 commits into
Draft
perf(guest): read the private input zero-copy via ef_io::read_input#886diegokingston wants to merge 2 commits into
diegokingston wants to merge 2 commits into
Conversation
get_private_input() to_vec()'s the whole memory-mapped input before rkyv deserializes it; read_input hands rkyv a slice straight into the input region instead. Same bytes, same private-input commitment. Measured vs origin/main (same fixtures, deterministic): transfers_20 8,732,213 -> 8,692,490 (-39,723) erc20_20 10,328,222 -> 10,278,822 (-49,400) mixed_20 9,817,444 -> 9,768,492 (-48,952) Verified: test_prove_ethrex_empty_block (prove+verify) passes.
Collaborator
Author
|
/bench |
Benchmark — real block (
|
| Metric | main | PR | Δ |
|---|---|---|---|
| Peak heap | 51856 MB | 51167 MB | -689 MB (-1.3%) ⚪ |
| Prove time | 159.217s | 147.340s | -11.877s (-7.5%) 🟢 |
❓ -7.5% — beyond what 3 runs resolve. Use
/bench-abbafor a paired test.Prove-time spread 1.5% (146.813s / 148.999s / 147.340s)
Commit: 383ccb8 · Baseline: cached · Runner: self-hosted bench
Collaborator
Author
|
/bench |
Collaborator
Author
|
/bench |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_private_input() to_vec()'s the whole memory-mapped input before rkyv deserializes it; read_input hands rkyv a slice straight into the input region instead. Same bytes, same private-input commitment.
Measured vs origin/main (same fixtures, deterministic):
transfers_20 8,732,213 -> 8,692,490 (-39,723)
erc20_20 10,328,222 -> 10,278,822 (-49,400)
mixed_20 9,817,444 -> 9,768,492 (-48,952)
Verified: test_prove_ethrex_empty_block (prove+verify) passes.