Repository navigation
[codex] add input method health diagnostics - #33
Merged
Merged
Conversation
ygsgdbd
marked this pull request as ready for review
August 14, 2026 10:08
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeSwitch previously treated input method discovery and automatic switching as best-effort operations without exposing whether the catalog was still loading, had failed, or whether a requested switch actually completed. A transient catalog failure could also look like an empty catalog and make valid saved rules appear unavailable.
This change adds explicit input method health and switch diagnostics to the menu bar UI. Users can now distinguish catalog loading or failure from a genuinely empty catalog, inspect the affected app and target input method after a switch failure, reload the catalog, retry the current app, and open Keyboard Settings when the configured input method is missing or disabled.
Root cause and user impact
Catalog fetch errors were collapsed into an empty array, so the reducer could not preserve the last known-good list or explain why input methods disappeared. Programmatic switches only returned a Boolean and relied on cancellation alone, which made stale asynchronous completions capable of affecting newer app activations. Retrying the current app also reused an asynchronously captured frontmost-app snapshot without a generation check.
As a result, users could see saved input method rules reported as missing during a transient failure, receive no explanation when a switch failed, or have an older asynchronous result overwrite newer foreground-app or catalog state.
Changes
TISSelectInputSourcesucceeds.Validation
rtk just checkgit diff --checkpassed before commit.