[codex] fix release recovery and input method race - #38
Merged
Merged
Conversation
ygsgdbd
marked this pull request as ready for review
August 21, 2026 08:00
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
ygsgdbd
enabled auto-merge
August 29, 2026 10:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change fixes the release workflow validation failure and two release/runtime recovery issues found while reviewing the changes since v0.9.0.
GitHub Actions rejected the release workflow because
concurrency.queueis not a supported workflow key. That prevented every version tag from starting a release. The workflow now uses the supported repository-wide concurrency group withcancel-in-progress: false, and PR checks install and runactionlintso invalid workflow schemas cannot be hidden by string-based script tests.Programmatic input-method switching could receive the successful system selection notification before its asynchronous verification returned a transient failure. The later failure then replaced the confirmed success and surfaced a false diagnostic to the user. Pending switch attempts now track whether the latest observed selection still matches the target. A matching notification prevents the transient failure from overwriting success, while a subsequent non-target notification revokes that confirmation. Statistics continue to count only completed
.switchedoutcomes.Failed GitHub Release publishes can leave a draft created by
softprops/action-gh-release. The release guard now distinguishes that recoverable draft from an already published Release. Drafts produce safe inspection, deletion, and failed-job rerun instructions; published Releases remain fail-closed and require a new SemVer tag. The recovery commands use a quotedFAILED_RUN_IDvariable so the documented shell snippets are executable rather than treating an angle-bracket placeholder as input redirection.The remaining limitation of GitHub Actions concurrency for three or more rapidly pushed release tags is recorded for future work and is intentionally not addressed here.
Validation
rtk just checkrtk actionlint .github/workflows/*.ymlrtk bash -n script/ensure_release_absent.sh script/test_release_scripts.shrtk git diff --check