Repository navigation
refactor: remove legacy defaults migration - #40
Merged
Merged
Conversation
ygsgdbd
marked this pull request as ready for review
August 29, 2026 11:10
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeSwitch has used the Sharing-backed file store since
v0.5.1, andv0.9.0shipped the final recovery migration for affected legacy rules. Keeping the old Defaults importer indefinitely now adds startup sequencing, directory scanning, dependencies, and tests for an upgrade path the project no longer intends to support.This change sets
v0.9.0+as the direct-upgrade compatibility baseline and:AppStorageCompatibilityTests;SwifterSwiftdependency and updates the English and Chinese dependency documentation;Existing Sharing storage paths, JSON schemas, and
MigrationVersionremain unchanged. The old Defaults keys are not actively deleted from user systems.Testing
xcodebuild test -project TypeSwitch.xcodeproj -scheme TypeSwitch -destination 'platform=macOS' -testLanguage zh-Hans -skipPackagePluginValidation -skipMacroValidation CODE_SIGN_IDENTITY='' CODE_SIGNING_ALLOWED=NO CODE_SIGNING_REQUIRED=NO— 131 tests, 0 failures.0.62.1lint — 0 of 43 files require formatting.script/test_release_scripts.sh— passed.Changelog
Select exactly one:
UnreleasedinCHANGELOG.md.Privacy