fix(release): preserve annotated tag during checkout - #42
Merged
Merged
Conversation
ygsgdbd
marked this pull request as ready for review
September 2, 2026 05:38
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/checkoutrewrites the local tag ref to the peeled commitRoot cause
The
v0.10.0tag is annotated on GitHub, but release run33594391034showedactions/checkout@v4fetching the peeled commit intorefs/tags/v0.10.0. The subsequentgit cat-file -ttherefore reportedcommitand stopped the release before any artifact or GitHub Release was created.Verification
tag->commit)tagwhilev0.10.0^{}remains1de88bc6d5a74598d27c2e1cf6830b248a3c0a0artk just check(SwiftFormat, 131 XCTest, release-script tests)rtk actionlint .github/workflows/*.ymlrtk git diff --checkRelease recovery
No
v0.10.0GitHub Release exists. After this PR is green and merged, the failed release will require a deliberate tag recovery because rerunning the old workflow would use the workflow definition from the original tag commit.