Skip to content

fix(release): preserve annotated tag during checkout - #42

Merged
ygsgdbd merged 1 commit into
mainfrom
codex/fix-release-tag-checkout
Sep 2, 2026
Merged

ygsgdbd merged 1 commit into
mainfrom
codex/fix-release-tag-checkout

Conversation

@ygsgdbd

@ygsgdbd ygsgdbd commented Sep 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • restore the remote annotated tag object after actions/checkout rewrites the local tag ref to the peeled commit
  • require that restore step to run before release-tag validation

Root cause

The v0.10.0 tag is annotated on GitHub, but release run 33594391034 showed actions/checkout@v4 fetching the peeled commit into refs/tags/v0.10.0. The subsequent git cat-file -t therefore reported commit and stopped the release before any artifact or GitHub Release was created.

Verification

  • reproduced the checkout ref overwrite in an isolated temporary repository (tag -> commit)
  • verified the restore fetch changes it back to tag while v0.10.0^{} remains 1de88bc6d5a74598d27c2e1cf6830b248a3c0a0a
  • rtk just check (SwiftFormat, 131 XCTest, release-script tests)
  • rtk actionlint .github/workflows/*.yml
  • rtk git diff --check

Release recovery

No v0.10.0 GitHub Release exists. After this PR is green and merged, the failed release will require a deliberate tag recovery because rerunning the old workflow would use the workflow definition from the original tag commit.

@ygsgdbd
ygsgdbd marked this pull request as ready for review September 2, 2026 05:38
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@ygsgdbd
ygsgdbd merged commit 440ef93 into main Sep 2, 2026
3 checks passed
@ygsgdbd
ygsgdbd deleted the codex/fix-release-tag-checkout branch September 2, 2026 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant