Repository navigation
Upload: Fix headers handling - #316
Merged
Merged
Conversation
BigRoy
reviewed
Apr 1, 2026
Member
There was a problem hiding this comment.
Should we never be allowed to specify any headers here?
Also, with this change - the 'fix' you're putting in core now will fail with the newer python API because you're explicitly passing headers there? 🤔
Member
Author
We should allow to specify headers (we do).
No, this just removes the |
BigRoy
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Fix headers being
None.Additional review information
Upload reviewable has defined
headerskwarg which is set toNonewhich is not expected to be in_upload_file.Testing notes:
upload_reviewablewithoutheaderskwarg should work.