Skip to content

chore: simplify contributor env setup - #403

Open
cameronapak wants to merge 2 commits into
mainfrom
ype-5843-root-env-setup
Open

cameronapak wants to merge 2 commits into
mainfrom
ype-5843-root-env-setup

Conversation

@cameronapak

@cameronapak cameronapak commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Use one root .env across dev harnesses.

Preserve overrides; fix dev:web and Turbo inputs.

YPE-5843

Greptile Summary

This PR consolidates contributor app-key configuration into a root .env while retaining package-local and explicit environment overrides.

  • Maps shared root configuration into the core tests, Vite example, and Storybook.
  • Updates Turbo environment inputs and repairs the dev:web workspace filter.
  • Replaces package-specific setup instructions and templates with root-level guidance.
  • Includes an intentional empty changeset for the tooling and documentation update.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
examples/vite-react/vite.config.ts Loads root and package environment files and maps shared app-key and API-host values into the Vite browser environment with explicit override precedence.
packages/ui/.storybook/main.ts Adds equivalent root and package environment resolution for Storybook while retaining explicit shell and CI overrides.
packages/core/package.json Extends core test scripts to load the root environment after package-local overrides.
turbo.json Declares the root environment file and relevant variables as Turbo task inputs for cache correctness.
package.json Repairs the web development command to run the Vite example and its workspace dependencies.
CONTRIBUTING.md Documents the consolidated root environment setup and override order.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  Root["Root .env"] --> Core["Core tests"]
  Root --> Vite["Vite example"]
  Root --> Storybook["Storybook"]
  Local["Package-local .env.local"] --> Core
  Local --> Vite
  Local --> Storybook
  Shell["Shell / CI variables"] --> Core
  Shell --> Vite
  Shell --> Storybook
  Turbo["Turbo environment inputs"] --> Core
  Turbo --> Vite
Loading

Reviews (2): Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." | Re-trigger Greptile

Context used:

Use one optional root .env for the core tests, Storybook, and Vite demo while preserving package-local and CI overrides. Fix the dev:web target and Turbo environment invalidation.

YPE-5843

Amp-Thread-ID: https://ampcode.com/threads/T-01a0a15f-295c-71cf-a9a8-6b02a36cba15
@changeset-bot

changeset-bot Bot commented Sep 14, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: b7d3a05

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cameronapak

Copy link
Copy Markdown
Collaborator Author

🚨 Breaking change detected — signoff required for v

This PR adds a changeset declaring a major bump, which would ship all three packages as v (they are a fixed group in .changeset/config.json, so they version together). Merging is blocked until a repo collaborator with write access comments on this PR with all four (4) of the following:

  1. The verbatim acknowledgment phrase below,
  2. The precise next version (v or ``),
  3. The full commit hash being approved (cf4fd7fd46f7fcb15da425d0a086c1ddb26aeca9), and
  4. A 🚀 (:rocket:) emoji.

I confirm that this is an intentional breaking change, and I have read the release procedures. I understand and have documented its impact upon release.

Copy-paste-ready reply:

I confirm that this is an intentional breaking change, and I have read the release procedures. I understand and have documented its impact upon release.

v cf4fd7fd46f7fcb15da425d0a086c1ddb26aeca9 🚀

The check re-runs automatically when a qualifying comment is posted or edited. Pushing new commits changes the hash, so a fresh signoff is needed.

question: Are empty change sets accounted for when it comes to this check?

Amp-Thread-ID: https://ampcode.com/threads/T-01a0ab8f-d490-72a8-858a-f8c7b602bf0f

# Conflicts:
#	packages/ui/.storybook/main.ts
#	packages/ui/.storybook/preview.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants