fix(ui): honor auth button mode - #417
Open
cameronapak wants to merge 1 commit into
Open
cameronapak wants to merge 1 commit into
cameronapak wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: b3955ad The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep
YouVersionAuthButtonactions aligned with their labels andmode. Explicit and default sign-in modes no longer sign authenticated users out;autostill follows auth state.Impacts consumers rendering the auth button while a session exists.
Verification
YVP_API_HOST, which is unavailable in the orbThe PR appears safe to merge, with the button action now consistently matching its configured mode and displayed label.
Summary
This PR aligns
YouVersionAuthButtonclick behavior with its displayed label and configured mode.isSignOutpredicate for both the rendered label and click action.automode.Reviews (1) · Last reviewed commit: "fix(ui): honor auth button mode"