docs(ui): define Shadow DOM rollout policy - #423
Merged
abharms merged 6 commits intoSep 25, 2026
Merged
Conversation
Reconcile YPE-5356 research into a coordinated package-wide rollout plan and focused implementation tickets.
Keep the production policy authoritative and remove stale or overly broad dependency language found during the YPE-5356 simplification audit.
Complete the public provider inventory and distinguish YPE-5946 branch results from browser coverage already present on YPE-5356.
🦋 Changeset detectedLatest commit: f531cbb The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
bmanquen
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes planning and compatibility documentation only. It does not expand runtime isolation:
YouVersionAuthButtonremains the only component automatically isolated on the integration branch.Requirement evidence
docs/shadow-dom-rollout-policy.mdinventories every public React UI export, identifies included roots and compound members, and gives a concrete reason for each exclusion.Accepted,Follow-up, orBlocker; stylesheet fallback recovery is the shared implementation blocker and real assistive-technology validation remains an explicit follow-up.Review scope
Required outcomes:
Permitted support work:
Non-goals:
Please treat a finding as blocking only when it identifies an unmet in-scope requirement, a documented repository-standard violation in added or modified code, or a concrete regression or defect caused or worsened by this diff. Label other valid improvements as non-blocking follow-ups.
Verification
pnpm lint— passedpnpm typecheck— passed, including UI build, public-entry/export checks, and style verificationpnpm test— passed: core 476 passed / 2 skipped, hooks 315 passed, UI 568 passedpnpm exec prettier --check <changed Markdown files>— passedgit diff --check— passedCompatibility and release notes
Textareais excluded from automatic isolation.Jira
YPE-5356 — Prepare the package-wide Shadow DOM rollout
The documentation-only PR appears safe to merge, with no unmet acceptance criterion, repository-rule violation, or concrete regression identified.
Summary
The PR defines the documentation-only policy for a coordinated major-version Shadow DOM rollout while preserving the current
YouVersionAuthButton-only runtime behavior.Diagram
%%{init: {'theme': 'neutral'}}%% flowchart TD F[YPE-5947 Shared boundary foundation] --> L[YPE-5948 Leaf and standalone components] F --> P[YPE-5949 Compound pickers] P --> S[YPE-5950 Scripture presentation] L --> R[YPE-5951 Bible reader] P --> R S --> R R --> G[YPE-5952 Coordinated major release] G --> D[Consumer documentation and release notes]Reviews (1) · Last reviewed commit: "docs(ui): correct rollout compatibility ..."