Repository navigation
Conversation
- Primary color teal.700 in light mode so white button text meets AA (was 3.7:1) - Dark-mode muted text surface.300 (was under 4:1 on cards) - Darker light-mode hero gradient so white hero text stays readable - Form errors use a dangerText token and role=alert instead of red-500 - Dialogs never exceed the viewport width on phones - Student name is a real link; notifications are buttons (keyboard access) - Labels for placeholder-only search fields
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
תיקון סעיפי P1 מבדיקת העיצוב.
מה השתנה
primary.700במקום 600. טקסט לבן על הכפתור עולה מ-3.7:1 ל-5.5:1 (תקן AA).surface.300במקום 400. היה מתחת ל-4:1 על כרטיסים.field-errorעל טוקן חדשdangerText(red-700 בבהיר, red-300 בכהה) במקוםtext-red-500(3.8:1), ועםrole="alert"כדי שקוראי מסך יקריאו אותן. 89 מקומות.max-widthגלובלי ל-.p-dialog, כך שאף דיאלוג ברוחב קבוע לא גולש מהמסך.aria-labelלשדות החיפוש והסינון בספרייה, בחיפוש המהיר ובמסכי הניהול, ולכפתור החיפוש בתקלות.בדיקה
ng buildעובר, ו-40 הבדיקות עוברות.