Add explicit websocket protocol for task services - #14
Merged
Merged
Conversation
Tasks annotated with protocol "websocket" get Envoy's websocket upgrade enabled on their routes via RouteAction.upgrade_configs; the upstream cluster stays HTTP/1.1. Upgrade is not enabled globally on the HCM, so http and grpc services are unaffected. Protocol is now part of the task version id so a protocol change re-renders the xDS snapshot. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
futujaos
self-requested a review
September 23, 2026 15:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
protocol: "websocket"value in thetask_proxyannotation, next tohttpandgrpc.RouteAction.upgrade_configswithupgrade_type: websocket,enabled: true. The upstream cluster stays HTTP/1.1. Upgrade is not enabled globally on the HCM, sohttpandgrpcservices are unaffected.ext_authzkeeps working as is: it runs on the upgrade request headers before the protocol switch.stream_idle_timeout_secondsstill applies to an idle WebSocket connection.Tests
discovery_test.go: parsing ofwebsocketin the annotation.xds_test.go: upgrade config is present on all routes of a websocket task, absent on http routes and on the HCM.task_test.go:ParseProtocoland protocol in the version id.gofmt,go vetandgo test ./...pass.🤖 Generated with Claude Code