ci(labels): use canonical label names in labeler config - #7
Open
ss-o wants to merge 2 commits into
Open
Conversation
The config named legacy labels that z-shell/.github#467 deleted org-wide. Map each key to its lib/labels.yml replacement and drop the unused i18n key. enhancement and maintenance both map to type:maintenance, so their glob lists merge into one key rather than being renamed one for one. Refs z-shell/.github#527
The config named legacy labels that z-shell/.github#467 deleted org-wide. Map each key to its lib/labels.yml replacement and drop the unused i18n key. enhancement and maintenance both map to type:maintenance, so their glob lists merge into one key rather than being renamed one for one. Refs z-shell/.github#527
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.github/labeler.ymlreferenced legacy labels that z-shell/.github#467 deleted across the organization.documentation ๐type:docsdependencies ๐ฆarea:dependenciesenhancement โจtype:maintenancemaintenance ๐type:maintenanceannex ๐/plugin โ๏ธ/package ๐ฆarea:annex/area:plugin/area:packageci ๐คarea:cii18n ๐Why it matters even where the labeler is off
actions/labelerapplies labels through the issues API, which creates a label that does not exist rather than failing. So a config naming deleted labels silently recreates them, undoing the org-wide cleanup, and nothing in CI reports it.That is latent rather than active here, and the retraction in z-shell/.github#527 has the detail: across the organization the labeler either could not authenticate or was disabled, so no recreation has actually occurred. This change is what keeps it latent if the workflow is ever enabled or the token ever fixed.
Three things worth a look rather than a skim
enhancement โจandmaintenance ๐both map totype:maintenance, so their glob lists merge into a single key rather than being renamed one for one.i18n ๐is dropped, not translated. It has no canonical equivalent and this repository has never used it. The only repository that does isz-shell/wiki, which does not drive it from a labeler config. It arrived from a Docusaurus-shaped template, which also explains any remainingcrowdin.yml,docusaurus.config.js, ornetlify.tomlglobs matching paths this repository does not have.Pruning the remaining template globs would be a real improvement and is deliberately left out, so this stays reviewable as a label-name correction.
Verified
Parsed with
yaml.safe_loadand checked againstlib/labels.yml: every resulting key is canonical, and the audit added in z-shell/.github#529 reports no findings for the result. Piloted inz-shell/z-a-submods, where after the equivalent change the labeler ran and applied the correct canonical label (z-a-submods#7).Part of z-shell/.github#527.