Skip to content

ci(labels): use canonical label names in labeler config - #7

Open
ss-o wants to merge 2 commits into
mainfrom
ci/canonical-labeler-config
Open

ci(labels): use canonical label names in labeler config#7
ss-o wants to merge 2 commits into
mainfrom
ci/canonical-labeler-config

Conversation

@ss-o

@ss-o ss-o commented Aug 19, 2026

Copy link
Copy Markdown
Member

.github/labeler.yml referenced legacy labels that z-shell/.github#467 deleted across the organization.

Was Now
documentation ๐Ÿ“ type:docs
dependencies ๐Ÿ“ฆ area:dependencies
enhancement โœจ type:maintenance
maintenance ๐Ÿ“ˆ type:maintenance
annex ๐ŸŒ€ / plugin โš™๏ธ / package ๐Ÿ“ฆ area:annex / area:plugin / area:package
ci ๐Ÿค– area:ci
i18n ๐ŸŒ removed

Why it matters even where the labeler is off

actions/labeler applies labels through the issues API, which creates a label that does not exist rather than failing. So a config naming deleted labels silently recreates them, undoing the org-wide cleanup, and nothing in CI reports it.

That is latent rather than active here, and the retraction in z-shell/.github#527 has the detail: across the organization the labeler either could not authenticate or was disabled, so no recreation has actually occurred. This change is what keeps it latent if the workflow is ever enabled or the token ever fixed.

Three things worth a look rather than a skim

  • enhancement โœจ and maintenance ๐Ÿ“ˆ both map to type:maintenance, so their glob lists merge into a single key rather than being renamed one for one.
  • i18n ๐ŸŒ is dropped, not translated. It has no canonical equivalent and this repository has never used it. The only repository that does is z-shell/wiki, which does not drive it from a labeler config. It arrived from a Docusaurus-shaped template, which also explains any remaining crowdin.yml, docusaurus.config.js, or netlify.toml globs matching paths this repository does not have.
  • Commented-out blocks are gone. The file is re-emitted from parsed YAML, which does not preserve comments. The removed blocks were disabled template leftovers, so nothing active is lost, but the diff is larger than a pure key rename.

Pruning the remaining template globs would be a real improvement and is deliberately left out, so this stays reviewable as a label-name correction.

Verified

Parsed with yaml.safe_load and checked against lib/labels.yml: every resulting key is canonical, and the audit added in z-shell/.github#529 reports no findings for the result. Piloted in z-shell/z-a-submods, where after the equivalent change the labeler ran and applied the correct canonical label (z-a-submods#7).

Part of z-shell/.github#527.

ss-o added 2 commits August 19, 2026 03:49
The config named legacy labels that z-shell/.github#467 deleted org-wide.
Map each key to its lib/labels.yml replacement and drop the unused i18n key.

enhancement and maintenance both map to type:maintenance, so their glob
lists merge into one key rather than being renamed one for one.

Refs z-shell/.github#527
The config named legacy labels that z-shell/.github#467 deleted org-wide. Map
each key to its lib/labels.yml replacement and drop the unused i18n key.

enhancement and maintenance both map to type:maintenance, so their glob lists
merge into one key rather than being renamed one for one.

Refs z-shell/.github#527
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant