ci(labeler): remove the disabled labeler workflow and its config - #53
Open
ss-o wants to merge 3 commits into
Open
ci(labeler): remove the disabled labeler workflow and its config#53ss-o wants to merge 3 commits into
ss-o wants to merge 3 commits into
Conversation
The config named legacy labels that z-shell/.github#467 deleted org-wide. Map each key to its lib/labels.yml replacement and drop the unused i18n key. enhancement and maintenance both map to type:maintenance, so their glob lists merge into one key rather than being renamed one for one. Refs z-shell/.github#527
The labeler workflow has been disabled_manually and has no recorded runs. A disabled workflow plus a config referencing labels that z-shell/.github#467 deleted is the worst of both: it does nothing today, and silently recreates legacy labels if anyone re-enables it, because actions/labeler creates a label that does not exist rather than failing. Remove both rather than maintain configuration for a workflow that is off. Re-adding later is a small change against the canonical label set. Refs z-shell/.github#527
The labeler workflow has been disabled_manually and has no recorded runs. A disabled workflow plus a config referencing labels that z-shell/.github#467 deleted is the worst of both: it does nothing today, and silently recreates legacy labels if anyone re-enables it, because actions/labeler creates a label that does not exist rather than failing. Remove both rather than maintain configuration for a workflow that is off. Re-adding later is a small change against the canonical label set. Refs z-shell/.github#527
ss-o
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the pull request labeler from this repository: both the workflow and its configuration.
Why remove rather than fix
The workflow is
disabled_manuallyand has no recorded runs. Leaving it in place with a configuration that names deleted labels is the worst of both outcomes: it does nothing today, and it silently recreates legacy labels the moment anyone re-enables it.That last part is the non-obvious bit.
actions/labelerapplies labels through the issues API, which creates a label that does not exist rather than failing. The config here referenced names that z-shell/.github#467 deleted across the organization, so re-enabling would have quietly undone that cleanup with nothing in any log to explain it.This pull request originally rewrote the config to canonical names. Deleting is the better answer: maintaining configuration for a switched-off workflow is upkeep with no payoff, and re-adding later is a small change written directly against the canonical set in
lib/labels.yml.What this does not do
It does not disable or remove labeling anywhere it is actually working. Repositories with an active labeler are being fixed rather than removed, keeping both the config and the workflow, in the pull requests listed on z-shell/.github#527.
Verification
.github/workflows/labeler.ymland.github/labeler.ymlare the only files touched. No other workflow references either path, and no other configuration depends on them.Part of z-shell/.github#527.