feat: bounded native HTTP serving and async file effects - #177
Merged
Merged
Conversation
Refs #176. Local draft only: eight transport tests, server-enabled suite, Clippy and feature isolation pass. Streaming, write-progress bounds, diagnostics and product adoption remain required before release.
Refs #176. Keep worker admission through cancellation and provide an infallible empty internal-error response.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #176. Coordinated with FastLED/cli#242 (draft application adoption), FastLED/cli#229 and FastLED/cli#239.
Adds optional facade-owned HTTP/1 serving with bounded connections, requests, response headers, file and SSE streaming, progress/deadline handling, cancellation and fixed-size diagnostics. Native file preparation, reads and screenshot writes retain bounded worker admission after cancellation. Product routing, authorization, MIME and browser-header policy stay in FastLED.
Validation: full local fs,http-server,event-stream suite and strict all-target Clippy pass; 22 focused HTTP integration tests pass; dependency isolation RED -> GREEN passes. One-agent pre-push review is clean. FastLED adoption passes 258 Rust workspace tests, strict all-target Clippy and 27 Python tests (one skipped), including malformed-request header-boundary coverage.
This upstream PR must merge and ship before exact registry adoption in FastLED. It does not close #176: native CI, published release and final application adoption remain required. No build-speed improvement claimed.