fix: verify registry packages and preserve external viewer isolation - #179
Merged
Merged
Conversation
Refs #155. Record the reproduced unpatched viewer failure; require the package gate before publication.
Refs #155. Replace checkout-only Git patches with one registry Wry version; remove injected scripts and IPC before navigation. Native isolation regression observed RED then GREEN.
Refs #155. Keep direct registry Wry 0.57 with os-webview, and run a native Windows isolation proof separately from compilation.
2 tasks done
Owner
Author
|
Final commit 89f7217 now passes soldr cargo package --locked --all-features -j1, including extracted-package compilation and binary linking. The initial all-features attempt failed only because this Nix host selected 32-bit xz/bzip2 libraries; explicit native pkg-config prefixes fixed the link, and the retry exited 0. Six native Linux viewer cases, final-graph targeted Rust tests, strict Clippy and formatting also passed. CI run 34745871318 has only Windows native still running; macOS native execution is skipped by repository policy. This is package verification, not publication. |
zackees
marked this pull request as ready for review
September 13, 2026 07:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #155. Coordinated with FastLED/cli#242. This upstream fix must merge and ship before exact published adoption in FastLED.
Changes
Evidence
Pending
All-features extracted-package verification is running locally. Native Windows and cross-target CI results are required before merge. Native macOS execution remains unavailable under the current runner policy. Publication credentials are not configured, and no release or build-speed improvement is claimed.
The isolation harness checks window.ipc, Tauri internals, and WebKit IPC, not absence of every platform-provided messaging object. See docs/registry-release-readiness.md.