feat: runtime-owned Ctrl+C notifications - #188
Merged
Merged
Conversation
This was referenced Sep 13, 2026
zackees
marked this pull request as ready for review
September 13, 2026 10:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #187 and #155. Coordinated with FastLED/cli#242. Stacked on #186.
Adds eager runtime-owned interrupt listeners and a lazy wait helper using the existing private signal driver. Disabled drivers return Unsupported; listener lifetime borrows the runtime. No new dependency, runtime or public backend type. Documents cancellation, coalescing and persistent process-wide handler effects.
RED missing API; GREEN default Linux suite (166 library tests plus integrations), isolated native eager/lazy/repeated/multiple-listener and cancellation tests, disabled-driver errors, compile-fail lifetime example, strict Linux/Windows Clippy, macOS ARM cross-check and formatting. One cross-repository reviewer is clean. Native Windows delivery requires CI.
FastLED adoption d8325c0 removes direct signal calls/backend pinning. Full app Rust tests, strict Clippy, formatting and Python checks (28 pass, one skip) pass. Selection/test macros remain outstanding. See docs/interrupt-notifications.md.
Keep #187 open until a usable exact release is published and consumed. This PR must merge before FastLED removes its migration-only sibling path override.