Conversation
RED: on Windows write_available falls back to the blocking write, so a client of a non-reading ConPTY can still park indefinitely. Refs FastLED/cli#259 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…ce, not for merge)
Owner
Author
|
Probe complete. Without the ConPTY change, the per-call test passed on windows-latest (run 35178784740): for 15 s of continuous 64 KiB writes against a ConPTY whose child never reads, every blocking-fallback call returned within 1.2 s. conhost keeps draining the input pipe, so the blocking write does not park on Windows. |
This was referenced Sep 17, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs the per-call bounded write test from #296 without the ConPTY fix, to record RED. Will be closed.
🤖 Generated with Claude Code