Repository navigation
Conversation
Every message an ACP parent sends to one of its subagents that is linked to the subagent's view of it is now drawn as a subagent card, like each native spawn_agent call. The card covers its part of the subagent's transcript: from the linked view up to the next message from the parent. Without a link, only the first message gets a card, which covers the whole subagent, as before. The subagent reports one state for all its work, and the protocol has no per-message outcome. A card for an earlier message therefore shows the first idle state the subagent reported after receiving it, which ended that message's work; until then it shows the current state, as the latest card does. AcpThread records each idle state an ACP subagent reports, with its entry count at the time, for this.
benbrandt
force-pushed
the
acp-subagent-delegation-cards
branch
from
October 28, 2026 13:12
ad00b90 to
19ae01f
Compare
benbrandt
marked this pull request as ready for review
October 28, 2026 13:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #66101 (linked session message views). Item 6 part 2 of the ACP subagents RFD work.
Until now an ACP parent's first message to a subagent was drawn as one card for the whole subagent, and later messages stayed "To …" rows. Native subagents get one card per
spawn_agentcall. This PR gives ACP subagents the same: one card per delegation.Which messages are cards
SendMessagedelegations.Status of earlier cards
The subagent reports one state for all its work, and the protocol has no per-message outcome. So:
AcpThreadrecords each idle state an ACP subagent reports, with its entry count at that time, for this (subagent_outcome_after). Replayed states are recorded in order, so earlier cards keep their outcome after a reload.cancel.Not changed: a card's full-screen button opens the subagent where it was last scrolled, as for native cards. The row link from #66101 jumps to the linked entry; doing the same here would also change native cards, so I've left it as a follow-up.
Testing
test_each_linked_message_to_an_acp_subagent_is_its_own_card:test_first_message_to_an_acp_subagent_shows_its_card(unlinked messages) passes unchanged.cargo nextest run -p acp_thread -p agent_servers -p agent_ui -p agent -p sidebar(2021 tests, rebased on main after Update agent-client-protocol to 3.6.0 (schema 1.13) #66245),./script/clippyandcargo fmtpass locally.Release Notes: