Repository navigation
fix(operator): prevent panic on empty ingress, improve concurrency, and add unit tests - #6
Open
Aphelios01-sdk wants to merge 1 commit into
Conversation
…nd add unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
crates/operator-common/src/types/load_balancer.rs, Kubernetes can return an empty ingress vector (ingress: []). Indexingingress[0].ipdirectly panicked the operator pod. Replaced with safe slice access (ingress.first() && first.ip.is_some()).wait()Loop:.unwrap()calls inwait()with safeOptionchecking and specific error propagation (IngressListMissing,IngressListEmpty,IPTimeout)._create():join_next().awaitout of the task spawn loop so tasks execute concurrently across load balancers. Propagated inner kube errors usingres??;instead of swallowing them.crates/operator/src/types/storage.rs.{name}-identitiesconfigmap incrates/operator/src/types/bootstrap.rs.