chore: key Bitcoin testnet4 DNS seeds - #4636
Open
daixiheguu wants to merge 1 commit into
Open
Conversation
Signed-off-by: daixiheguu <daixihegu@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use keyed
chaincfg.DNSSeedliterals for the Bitcoin testnet4 seeds. This removes the unkeyed-field vet warning and makes it clear that each value setsHostandHasFiltering.There is no behavior change.
How Has This Been Tested?
Note
Low Risk
Cosmetic struct literal change in testnet4 chain params; no logic, security, or data-path impact.
Overview
Updates
TestNet4Params.DNSSeedsinbitcoin_testnet4.goto use explicitHostandHasFilteringfields on eachchaincfg.DNSSeedentry instead of positional struct literals.This is a readability and static-analysis fix only—the same two seeds and filtering flag as before, with no runtime or networking behavior change.
Reviewed by Cursor Bugbot for commit 0194e6c. Configure here.
Greptile Summary
The PR replaces positional Bitcoin testnet4 DNS seed literals with equivalent keyed
HostandHasFilteringfields, improving clarity and eliminating the unkeyed-field vet warning without changing configured values.Confidence Score: 5/5
The PR appears safe to merge because it preserves the existing DNS seed values and behavior.
The only changes replace positional struct initialization with explicit field names while retaining identical host strings and filtering values, and no actionable defect was identified.
Important Files Changed
chaincfg.DNSSeedvalues to keyed literals while preserving their hosts and filtering settings.Reviews (1): Last reviewed commit: "chore: key Bitcoin testnet4 DNS seeds" | Re-trigger Greptile