Skip to content

chore: key Bitcoin testnet4 DNS seeds - #4636

Open
daixiheguu wants to merge 1 commit into
zeta-chain:mainfrom
daixiheguu:chore-key-bitcoin-dns-seeds
Open

chore: key Bitcoin testnet4 DNS seeds#4636
daixiheguu wants to merge 1 commit into
zeta-chain:mainfrom
daixiheguu:chore-key-bitcoin-dns-seeds

Conversation

@daixiheguu

@daixiheguu daixiheguu commented Aug 27, 2026

Copy link
Copy Markdown

Description

Use keyed chaincfg.DNSSeed literals for the Bitcoin testnet4 seeds. This removes the unkeyed-field vet warning and makes it clear that each value sets Host and HasFiltering.

There is no behavior change.

How Has This Been Tested?

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Note

Low Risk
Cosmetic struct literal change in testnet4 chain params; no logic, security, or data-path impact.

Overview
Updates TestNet4Params.DNSSeeds in bitcoin_testnet4.go to use explicit Host and HasFiltering fields on each chaincfg.DNSSeed entry instead of positional struct literals.

This is a readability and static-analysis fix only—the same two seeds and filtering flag as before, with no runtime or networking behavior change.

Reviewed by Cursor Bugbot for commit 0194e6c. Configure here.

Greptile Summary

The PR replaces positional Bitcoin testnet4 DNS seed literals with equivalent keyed Host and HasFiltering fields, improving clarity and eliminating the unkeyed-field vet warning without changing configured values.

  • Preserves both existing testnet4 DNS seed hosts.
  • Preserves DNS filtering as enabled for each seed.

Confidence Score: 5/5

The PR appears safe to merge because it preserves the existing DNS seed values and behavior.

The only changes replace positional struct initialization with explicit field names while retaining identical host strings and filtering values, and no actionable defect was identified.

Important Files Changed

Filename Overview
pkg/chains/bitcoin_testnet4.go Converts two chaincfg.DNSSeed values to keyed literals while preserving their hosts and filtering settings.

Reviews (1): Last reviewed commit: "chore: key Bitcoin testnet4 DNS seeds" | Re-trigger Greptile

Signed-off-by: daixiheguu <daixihegu@outlook.com>
@daixiheguu
daixiheguu requested a review from a team as a code owner August 27, 2026 15:36

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant