Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #8 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 1185 1187 +2
=========================================
+ Hits 1185 1187 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Local ZDO responses do not yet propagate APS_Encryption to emitted replies.
Review effort: Lite
Findings: None
What changed in this PR
Adds aps_encrypted support so encrypted incoming Zigbee frames can request encrypted replies, while removing Ziggurat-managed aps_seq handling.
Changes:
- Adds APS encryption metadata to received frames.
- Propagates encryption state to transmit options.
- Updates wire builders and tests for the revised format.
| File | Description |
|---|---|
zigpy_ziggurat/zigbee/wire.py |
Updates wire structures and encryption bitfields. |
zigpy_ziggurat/zigbee/protocol.py |
Adjusts builders for the revised wire format. |
zigpy_ziggurat/zigbee/application.py |
Propagates incoming encryption state. |
tests/test_application.py |
Tests encryption handling and updated payloads. |
tests/test_api.py |
Updates API fixtures and assertions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
zigpy-review-bot
added
new feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
aps_encryptedbit is set by Ziggurat when an incoming frame was encrypted by the device. Zigpy can react to this information to send back an encrypted reply.The wire format has changed ever so slightly and Ziggurat no longer handles
aps_seqso this PR is ever so slightly larger than necessary for this one change.